Review main Merged

44734[BUGFIX] IE: make save button usable

Andreas Allacher CR +2 V +2 Easy +1 −1 updated 11/16/15, 11:51

Commit message

Correctly handling of save button for IE.
Due to IE not supporting form attribute on button
the save button doesn't work currently.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
  • Verified V +2
    • Andreas Kienast +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 6

  1. Andreas Allacher uploaded patch set 1 11/16/15, 11:46

  2. Mathias Schreiber commented on patch set 1 CR +1 V +1 11/16/15, 11:48

    neat little polyfill :)
  3. Andreas Kienast commented on patch set 1 V -1 11/16/15, 11:49

    Save & Close does not work, tested in Extension Manager
  4. Andreas Kienast commented on patch set 1 CR +2 V +2 11/16/15, 11:50

    not related to that patch...
  5. Gerrit merged patch set 1 11/16/15, 11:50

  6. Andreas Allacher commented on patch set 2 11/16/15, 11:51

    Ah great. Just wanted to test that, although normal save and close worked for me. Maybe only in EM ?