Review main Merged

44747[BUGFIX] Show nav title in element browser

Marco Huber CR +2 V +2 Normal +43 −32 updated 11/18/15, 10:31

Commit message

Show the nav title instead of the page title in the element browser
(f.e. in the link wizard), if the user TSconfig setting
"options.pageTree.showNavTitle=1" is set.

Review

  • Code review CR +2
    • Markus Klein +2
    • Marco Huber +1
  • Verified V +2
    • Markus Klein +2
    • Marco Huber +1
    • Gianluigi Martino +1

Issues 2

Files 4

Review log 15

  1. Marco Huber uploaded patch set 1 11/17/15, 13:02

  2. Markus Klein commented on patch set 1 CR -1 V -1 11/17/15, 13:11

    BrowseTreeView.php:138

    this memember is NOT defined in this class
  3. Markus Klein commented on patch set 1 11/17/15, 13:13

    The handling has to go into \TYPO3\CMS\Backend\View\PageTreeView I presume
  4. Marco Huber uploaded patch set 2 11/17/15, 13:20

  5. Marco Huber commented on patch set 1 11/17/15, 13:26

    @Markus: Why? The same is implemented in TYPO3\CMS\Backend\Tree\View\PageTreeView and my patch just fixes a bug introduced with http://forge.typo3.org/issues/64492
  6. Markus Klein commented on patch set 2 CR -1 11/17/15, 13:45

    The member is also defined in inheriting classes, will clean that up
  7. Markus Klein uploaded patch set 3 11/17/15, 13:55

  8. Markus Klein voted on patch set 3 CR +1 11/17/15, 13:56

  9. Marco Huber uploaded patch set 4 11/17/15, 13:57

  10. Markus Klein uploaded patch set 5 11/17/15, 14:01

  11. Markus Klein voted on patch set 5 CR +1 11/17/15, 14:02

  12. Marco Huber voted on patch set 5 CR +1 V +1 11/17/15, 14:10

  13. Gianluigi Martino voted on patch set 5 V +1 11/18/15, 08:34

  14. Markus Klein voted on patch set 5 CR +2 V +2 11/18/15, 10:31

  15. Gerrit merged patch set 5 11/18/15, 10:31