Review main Merged

44764[BUGFIX] Handle pageTSconfig correctly for TS

Markus Klein CR +2 V +2 Normal +55 −7 updated 11/18/15, 10:29

Commit message

The page TSconfig includes need to be processed for TypoScript
as well in order to have constants from TSconfig available.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Andreas Wolf +1
  • Verified V +2
    • Jigal van Hemert +2
    • Andreas Wolf +1

Issues 1

Files 3

Review log 8

  1. Markus Klein uploaded patch set 1 11/17/15, 19:52

  2. Markus Klein uploaded patch set 2 11/17/15, 23:08

  3. Andreas Wolf uploaded patch set 3 11/18/15, 08:18

  4. Andreas Wolf uploaded patch set 4 11/18/15, 08:55

  5. Andreas Wolf voted on patch set 4 CR +1 V +1 11/18/15, 08:56

  6. Jigal van Hemert commented on patch set 4 CR +2 V +2 11/18/15, 10:22

    Tested by registering a constants file in a sitepackage and looking up the constants in the TS object browser.
  7. Gerrit merged patch set 4 11/18/15, 10:22

  8. Wouter Wolters commented on patch set 5 11/18/15, 10:29

    ExtensionManagementUtility.php:1484

    misses @throws phpdoc