44766[BUGFIX] Restore clear cache menu icon if clearing fatals
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Daniel L +1
- Christian Kuhn +1
-
Verified V +2
- Markus Klein +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 10
-
Andreas Kienast uploaded patch set 1 11/18/15, 07:57
-
Wouter Wolters voted on patch set 1 CR +1 11/18/15, 08:00
-
Josef Glatz commented on patch set 1 11/18/15, 08:08
-
Andreas Kienast commented on patch set 2 11/18/15, 08:10
Published edit on patch set 1 -
Christian Kuhn commented on patch set 2 11/18/15, 12:58
hey. in general +1 (did not really test it though). However, there is one thing that i find specifically annoying: If a clear-cache isn't successful for instance if a session expired, there is no message what so ever. It would be MUCH better if a message (callout? / flash message?) is created in this case wiht "hey, your clear cache did not work out!". Would something like that be do-able Andreas? Maybe with a different patch? -
Christian Kuhn voted on patch set 2 CR +1 V +1 11/18/15, 13:00
-
Daniel L voted on patch set 2 CR +1 11/18/15, 13:31
-
Andreas Kienast commented on patch set 2 11/18/15, 15:45
@Christian: As discussed in Slack: It's possible, but that requires that I can identify the reason for the failed request in the response. I'd rather add a generic failure handler for all requests that simply prints a notification why the AJAX request failed. -
Markus Klein commented on patch set 2 CR +2 V +2 11/18/15, 16:02
+1 for the additional error handling! -
Gerrit merged patch set 2 11/18/15, 16:02
ClearCacheMenu.js:51