Review main Merged

44794[BUGFIX] Fix fatal error in SpacelessViewHelper

Wouter Wolters CR +2 V +2 Normal +39 −18 updated 11/19/15, 15:35

Commit message

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1

Issues 1

Files 2

Review log 17

  1. Wouter Wolters uploaded patch set 1 11/19/15, 12:10

  2. Markus Klein voted on patch set 1 CR +1 V +1 11/19/15, 12:50

  3. Michael Oehlhof voted on patch set 1 CR +1 11/19/15, 12:52

  4. Anja Leichsenring commented on patch set 1 CR -1 11/19/15, 12:53

    please wait, still on it.
  5. Anja Leichsenring uploaded patch set 2 11/19/15, 14:15

  6. Philipp Gampe voted on patch set 2 CR +1 V +1 11/19/15, 14:21

  7. Wouter Wolters commented on patch set 2 CR +1 V +1 11/19/15, 14:44

    Waiting for Markus to return and give his votes.
  8. Nicole Hummel commented on patch set 2 11/19/15, 14:49

    SpacelessViewHelper.php:57

    Superfluous empty line

    SpacelessViewHelper.php:58

    According to the documentation trim() always returns a string

    SpacelessViewHelperTest.php:33

    []

    SpacelessViewHelperTest.php:34

    The comment should go into the test name

    SpacelessViewHelperTest.php:42

    dataProvider functions always have the name of the test + DataProvider => testRenderStaticDataProvider

    SpacelessViewHelperTest.php:49

    []

    SpacelessViewHelperTest.php:57

    s.a.

    SpacelessViewHelperTest.php:71

    []
  9. Nicole Hummel commented on patch set 3 11/19/15, 14:55

    Published edit on patch set 2
  10. Nicole Hummel commented on patch set 4 11/19/15, 14:56

    Published edit on patch set 3
  11. Anja Leichsenring commented on patch set 5 11/19/15, 15:04

    Published edit on patch set 4
  12. Anja Leichsenring commented on patch set 5 11/19/15, 15:05

    Please leave the comment intact. It helps to understand the motivation of the test. Thank you.
  13. Anja Leichsenring commented on patch set 6 11/19/15, 15:09

    Published edit on patch set 5
  14. Markus Klein voted on patch set 6 CR +1 V +1 11/19/15, 15:10

  15. Wouter Wolters voted on patch set 6 CR +1 V +1 11/19/15, 15:14

  16. Nicole Hummel voted on patch set 6 CR +2 V +2 11/19/15, 15:35

  17. Gerrit merged patch set 6 11/19/15, 15:35