44794[BUGFIX] Fix fatal error in SpacelessViewHelper
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Nicole Hummel +2
- Markus Klein +1
- Wouter Wolters +1
Issues 1
Files 2
Review log 17
-
Wouter Wolters uploaded patch set 1 11/19/15, 12:10
-
Markus Klein voted on patch set 1 CR +1 V +1 11/19/15, 12:50
-
Michael Oehlhof voted on patch set 1 CR +1 11/19/15, 12:52
-
Anja Leichsenring commented on patch set 1 CR -1 11/19/15, 12:53
please wait, still on it. -
Anja Leichsenring uploaded patch set 2 11/19/15, 14:15
-
Philipp Gampe voted on patch set 2 CR +1 V +1 11/19/15, 14:21
-
Wouter Wolters commented on patch set 2 CR +1 V +1 11/19/15, 14:44
Waiting for Markus to return and give his votes. -
Nicole Hummel commented on patch set 2 11/19/15, 14:49
SpacelessViewHelper.php:57Superfluous empty lineSpacelessViewHelper.php:58According to the documentation trim() always returns a stringSpacelessViewHelperTest.php:33[]SpacelessViewHelperTest.php:34The comment should go into the test nameSpacelessViewHelperTest.php:42dataProvider functions always have the name of the test + DataProvider => testRenderStaticDataProviderSpacelessViewHelperTest.php:49[]SpacelessViewHelperTest.php:57s.a.SpacelessViewHelperTest.php:71[] -
Nicole Hummel commented on patch set 3 11/19/15, 14:55
Published edit on patch set 2 -
Nicole Hummel commented on patch set 4 11/19/15, 14:56
Published edit on patch set 3 -
Anja Leichsenring commented on patch set 5 11/19/15, 15:04
Published edit on patch set 4 -
Anja Leichsenring commented on patch set 5 11/19/15, 15:05
Please leave the comment intact. It helps to understand the motivation of the test. Thank you. -
Anja Leichsenring commented on patch set 6 11/19/15, 15:09
Published edit on patch set 5 -
Markus Klein voted on patch set 6 CR +1 V +1 11/19/15, 15:10
-
Wouter Wolters voted on patch set 6 CR +1 V +1 11/19/15, 15:14
-
Nicole Hummel voted on patch set 6 CR +2 V +2 11/19/15, 15:35
-
Gerrit merged patch set 6 11/19/15, 15:35