Review main Merged

44802[BUGFIX] Hide shortcuts to inaccessible modules for admins as well

Patrick Schriner CR +2 V +2 Easy +5 −5 updated 11/21/15, 16:12

Commit message

Currently the check whether a module is accessible is only done for
non-admins. Clicking on a shortcut that leads to an inaccessible module leads
to an error. Move the check outside so that those shortcuts are at least
not shown after a backend reload.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 8

  1. Patrick Schriner uploaded patch set 1 11/19/15, 16:26

  2. Patrick Schriner updated the commit message in patch set 2 11/19/15, 16:27

  3. Andreas Kienast commented on patch set 3 11/20/15, 15:13

    Published edit on patch set 2
  4. Andreas Kienast voted on patch set 3 CR +1 V +1 11/20/15, 15:14

  5. Wouter Wolters voted on patch set 3 CR +1 11/20/15, 15:19

  6. Wouter Wolters voted on patch set 3 V +1 11/21/15, 16:11

  7. Markus Klein voted on patch set 3 CR +2 V +2 11/21/15, 16:12

  8. Gerrit merged patch set 3 11/21/15, 16:12