Review main Merged

44805[BUGFIX] Prevent fatal error in stdWrap when compatibility6 is not loaded

Markus Klein CR +2 V +2 Easy +20 −15 updated 11/19/15, 19:56

Commit message

When extracting compatibility6 it was forgotten to tackle stdWrap offsetWrap,
which uses a class of compatibility6.

We add a check for the extension and a deprecation notice to not use this
(really outdated) stdWrap anymore.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 5

  1. Markus Klein uploaded patch set 1 11/19/15, 17:49

  2. Stefan Neufeind commented on patch set 1 CR +1 V +1 11/19/15, 17:54

    verified by reading :-)
  3. Stefan Neufeind commented on patch set 1 11/19/15, 17:55

    We already discussed with Mattes that we'll handle it this way.
  4. Georg Ringer voted on patch set 1 CR +2 V +2 11/19/15, 18:33

  5. Gerrit merged patch set 1 11/19/15, 19:56