Review main Merged

44807[SECURITY][TASK] Blind more options in the configuration module

Georg Ringer CR +2 V +2 Easy +27 −4 updated 11/20/15, 08:56

Commit message

The database credentials should not be shown in the configuration module.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Martin Kutschker +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Martin Kutschker +1

Issues 2

Files 1

Review log 9

  1. Georg Ringer uploaded patch set 1 11/19/15, 20:30

  2. Wouter Wolters commented on patch set 2 11/19/15, 20:45

    Published edit on patch set 1
  3. Wouter Wolters voted on patch set 2 CR +1 V +1 11/19/15, 20:45

  4. Georg Ringer uploaded patch set 3 11/19/15, 20:56

  5. Georg Ringer uploaded patch set 4 11/19/15, 20:58

  6. Wouter Wolters commented on patch set 4 CR +1 V +1 11/19/15, 21:01

    Socket is added here but could be that it is not in use. I'm fine with that.
  7. Martin Kutschker voted on patch set 4 CR +1 V +1 11/19/15, 21:28

  8. Georg Ringer voted on patch set 4 CR +2 V +2 11/20/15, 08:56

  9. Gerrit merged patch set 4 11/20/15, 08:56