Review main Merged

44832[BUGFIX] Check webmounts for backend user in workspace preview

Nicole Hummel CR +2 V +2 Easy +16 −4 updated 11/22/15, 12:01

Commit message

This patch adds a check if the current backend user used for workspace
authentication has access to the current requested page. If the user
doesn't have access the workspace version of that page can't be displayed
and the live version is shown instead.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Nicole Hummel +1

Issues 1

Files 1

Review log 16

  1. Nicole Hummel uploaded patch set 1 11/20/15, 15:38

  2. Andreas Kienast voted on patch set 1 CR +1 11/20/15, 15:40

  3. Markus Klein commented on patch set 2 11/20/15, 15:45

    Published edit on patch set 1
  4. Markus Klein voted on patch set 2 CR +1 11/20/15, 15:45

  5. Oliver Hader voted on patch set 2 CR +1 11/20/15, 15:48

  6. Oliver Hader commented on patch set 2 11/20/15, 15:50

  7. Andreas Kienast voted on patch set 2 CR +1 11/20/15, 15:56

  8. Oliver Hader voted on patch set 2 V +1 11/20/15, 16:53

  9. Oliver Hader commented on patch set 2 11/20/15, 16:54

    Can be tested by creating a preview link
  10. Stefan Neufeind voted on patch set 2 CR +1 11/21/15, 12:34

  11. Mathias Schreiber commented on patch set 3 11/22/15, 11:00

    Published edit on patch set 2
  12. Mathias Schreiber commented on patch set 3 CR +1 V +1 11/22/15, 11:00

    Just reformatting according to CGL and minor edit in the commit message. Apart from that: well done
  13. Stefan Neufeind voted on patch set 3 CR +1 11/22/15, 11:03

  14. Nicole Hummel voted on patch set 3 CR +1 V +1 11/22/15, 11:39

  15. Markus Klein voted on patch set 3 CR +2 V +2 11/22/15, 12:01

  16. Gerrit merged patch set 3 11/22/15, 12:01