44843[TASK] Fluidification of RecordHistory
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
Issues 1
Files 6
- typo3/sysext/backend/Classes/History/RecordHistory.php2+122 −162
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/Diff.htmlnew+12 −0
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/History.htmlnew+59 −0
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/MultipleDiff.htmlnew+34 −0
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/Settings.htmlnew+76 −0
- typo3/sysext/backend/Resources/Private/Templates/RecordHistory/Main.htmlnew+14 −0
Review log 17
-
Jan Helke uploaded patch set 1 11/20/15, 21:09
-
Jan Helke uploaded patch set 2 11/20/15, 21:16
-
Jan Helke uploaded patch set 3 11/20/15, 21:18
-
Jan Helke uploaded patch set 4 01/10/16, 11:35
-
Jan Helke uploaded patch set 5 01/22/16, 15:45
-
Jan Helke uploaded patch set 6 01/22/16, 16:41
-
Jan Helke uploaded patch set 7 01/22/16, 16:49
-
Jan Helke uploaded patch set 8 01/22/16, 16:59
-
Jan Helke uploaded patch set 9 01/22/16, 17:15
-
Frank Nägler commented on patch set 9 01/22/16, 17:40
locallang.xlf:85tabs instead of spaces -
Christian Kuhn commented on patch set 9 01/22/16, 17:41
locallang.xlf:86i'd opt to not duplicate these labels. my gut feeling says elementHistoryController and recordHistory classes should be merged to one class later, anyway, so this label duplication doesn't make much sense from this point of view, too. -
Jan Helke uploaded patch set 10 01/22/16, 18:04
-
Jan Helke commented on patch set 10 01/22/16, 18:05
RecordHistory.php:567ReplyDonelocallang.xlf:85ReplyDonelocallang.xlf:86ReplyDone -
Christian Kuhn uploaded patch set 11 01/22/16, 18:09
-
Frank Nägler commented on patch set 11 CR +1 V +1 01/22/16, 18:09
still some cleanups required, but state is ok now, lets get it in. -
Christian Kuhn voted on patch set 11 CR +2 V +2 01/22/16, 18:15
-
Gerrit merged patch set 11 01/22/16, 18:15
RecordHistory.php:567