Review main Abandoned

44864[WIP][TASK] Improve Validation and Processing of fields in FormEngine

Frank Nägler CR 0 V 0 Expert +1664 −678 updated 08/18/17, 08:27

Commit message

/!\ This is currently a very early proof of concept. /!\

This patch introduce a split of validators and processors for fields in FormEngine.
This patch introduce interfaces for processors and validators and remove the eval
string list from TCA step by step. A TcaMigration handle the migration.

Please do not make changes and push new sets at the moment, please talk to me
on slack if you have ideas or concerns, or leave your comments on gerrit.

Review

  • Code review CR 0
  • Verified V 0

Files 22

Show 2 more files

Review log 10

  1. Frank Nägler uploaded patch set 1 11/21/15, 15:57

  2. Frank Nägler voted on patch set 1 CR -2 11/21/15, 15:58

  3. Frank Nägler uploaded patch set 2 11/22/15, 12:50

  4. Frank Nägler uploaded patch set 3 11/22/15, 14:48

  5. Frank Nägler uploaded patch set 4 01/04/16, 15:20

  6. Frank Nägler uploaded patch set 5 01/04/16, 15:31

  7. Andreas Kienast commented on patch set 5 01/04/16, 17:07

    WhiteListCharacter.js:35

    I guess something like ``var regexp = new RegExp('[^' + options.is_in + ']');theValue.replace(regexp, '');`` is better here.
  8. Frank Nägler commented on patch set 5 01/04/16, 17:15

    WhiteListCharacter.js:35 Reply

    I don't want change the existing logic with this patch. Better change this later. But currently this patch has a main problem with the async loading of the processor modules. See my comment in FormEngineValidation.js line 278 ff. Maybe you have an idea? ;)
  9. Frank Nägler uploaded patch set 6 05/30/16, 07:48

  10. Frank Nägler abandoned the change 08/18/17, 08:27