44883[TASK] Provide trait to prevent unserializing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Error/PreventUnserializeTrait.phpnew+30 −0
- typo3/sysext/core/Classes/Service/AbstractService.php+5 −0
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+5 −0
- typo3/sysext/extensionmanager/Tests/Unit/Controller/UploadExtensionFileControllerTest.php+13 −0
- typo3/sysext/saltedpasswords/Tests/Unit/SaltedPasswordServiceTest.phpnew+33 −0
- typo3/sysext/sv/Tests/Unit/AuthenticationServiceTest.php+12 −0
Review log 10
-
Stefan Neufeind uploaded patch set 1 11/21/15, 18:45
-
Stefan Neufeind commented on patch set 1 11/21/15, 18:46
Up for discussion. Unit-test works for me. -
Helmut Hummel commented on patch set 1 11/22/15, 09:19
PreventUnserialize.php:22must end with "Trait" which makes it "PreventUnserializeTrait" -
Helmut Hummel commented on patch set 2 11/22/15, 11:19
Published edit on patch set 1 -
Valentin Despa uploaded patch set 3 11/22/15, 13:51
-
Valentin Despa uploaded patch set 4 11/22/15, 14:12
-
Christian Kuhn commented on patch set 4 03/31/16, 21:56
with the second parameter on unserialize() in php7, this feature is obsolete. abandoned. -
Christian Kuhn abandoned the change 03/31/16, 21:56
-
Stefan Neufeind commented on patch set 4 05/02/16, 09:16
Right, thanks. But doing a quick grep the to-do might then instead be to check unserialize()-calls and make use of the second parameter wherever possible. -
Stefan Neufeind commented on patch set 4 05/02/16, 09:18
Just found there is a separate ticket for securing unserialze. So we can definitely call this here resolved.