Review main Abandoned

44883[TASK] Provide trait to prevent unserializing

Stefan Neufeind CR 0 V 0 Normal +98 −0 updated 05/02/16, 09:18

Commit message

This can be used as a security-measure against unplanned unserialization
used as an attack-vector.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 10

  1. Stefan Neufeind uploaded patch set 1 11/21/15, 18:45

  2. Stefan Neufeind commented on patch set 1 11/21/15, 18:46

    Up for discussion. Unit-test works for me.
  3. Helmut Hummel commented on patch set 1 11/22/15, 09:19

    PreventUnserialize.php:22

    must end with "Trait" which makes it "PreventUnserializeTrait"
  4. Helmut Hummel commented on patch set 2 11/22/15, 11:19

    Published edit on patch set 1
  5. Valentin Despa uploaded patch set 3 11/22/15, 13:51

  6. Valentin Despa uploaded patch set 4 11/22/15, 14:12

  7. Christian Kuhn commented on patch set 4 03/31/16, 21:56

    with the second parameter on unserialize() in php7, this feature is obsolete. abandoned.
  8. Christian Kuhn abandoned the change 03/31/16, 21:56

  9. Stefan Neufeind commented on patch set 4 05/02/16, 09:16

    Right, thanks. But doing a quick grep the to-do might then instead be to check unserialize()-calls and make use of the second parameter wherever possible.
  10. Stefan Neufeind commented on patch set 4 05/02/16, 09:18

    Just found there is a separate ticket for securing unserialze. So we can definitely call this here resolved.