44884[BUGFIX] Wizard element browser shows FlashMessage for invalid identifier
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 4549
Show 24 earlier messages
-
Michael Oehlhof uploaded patch set 1 11/21/15, 20:19
-
Wouter Wolters commented on patch set 1 CR -1 11/22/15, 09:34
LinkBrowserController.php:55catch on the same line as closing bracket -
Michael Oehlhof uploaded patch set 2 11/22/15, 11:43
-
Frank Nägler commented on patch set 2 CR -1 11/23/15, 10:00
LinkBrowserController.php:92why not move this code into initCurrentUrl method? Imho no new property is required, the flashMessage can be generated where the problem is detected. -
Michael Oehlhof uploaded patch set 3 11/23/15, 18:02
-
Andreas Bouche commented on patch set 3 V -1 11/24/15, 12:10
I'm getting a fatal error now in renderCurrentUrl, as currentLinkHandler will not be set. -
Andreas Bouche uploaded patch set 4 11/24/15, 12:16
-
Michael Oehlhof voted on patch set 4 CR +1 V +1 11/24/15, 12:45
-
Markus Klein commented on patch set 4 11/24/15, 13:25
LinkBrowserController.php:54makeInstance() -
Andreas Bouche uploaded patch set 5 11/24/15, 14:03
-
Markus Klein commented on patch set 5 CR -1 11/24/15, 14:17
Sorry for not coming up earlier with this comment: I think this should be handled in the handlers, as this is specific to the link type. -
Andreas Bouche commented on patch set 5 11/24/15, 15:09
Hmm, this would produce 2 FlashMessages, since "file" and "folder" use the same Handler. I'm not sure how to avoid this without modifying the controller. Still better than an uncaught exception, though. -
Markus Klein commented on patch set 5 11/24/15, 16:43
Then I suggest to throw a custom exception "InvalidCurrentLinkExeception" in the handler, so this is generic then and will stop with the first handler that feels responsible for a link, but fails to verify it (for whatever reason). -
Benni Mack commented on patch set 5 03/31/16, 17:08
michael, care to update the patch? -
Michael Oehlhof commented on patch set 5 04/01/16, 07:28
I can take a look on it at the weekend. -
Michael Oehlhof uploaded patch set 6 04/03/16, 19:57
-
Markus Klein commented on patch set 6 04/03/16, 21:30
LinkBrowserController.php:48not sure about the namespace. To my knowledge this area is more for FAL.InvalidCurrentLinkExeception.php:15no indentation here please.InvalidCurrentLinkExeception.php:21This exception should not be limited to FAL, but could be used by any other LinkHandler of any type to indicate a broken link. So it should not extend the base exception from FAL IMO.AbstractLinkBrowserController.php:177I guess we can remove that part.BrowseLinksController.php:268Since this is exactly the same code for both places, what about putting that directly into the parent method? -
Michael Oehlhof uploaded patch set 7 04/03/16, 23:03
-
Markus Klein commented on patch set 8 04/04/16, 08:21
Published edit on patch set 7. -
Markus Klein commented on patch set 8 04/04/16, 08:22
Just removed useless use statements, will review again a bit later. -
Andreas Kienast commented on patch set 8 04/04/16, 08:24
AbstractLinkBrowserController.php:179&& -
Michael Oehlhof commented on patch set 9 04/04/16, 21:01
Published edit on patch set 8. -
Markus Klein uploaded patch set 10 04/05/16, 08:37
-
Markus Klein uploaded patch set 11 04/05/16, 08:38
-
Markus Klein commented on patch set 11 CR +1 04/05/16, 08:39
I moved the exception now to a better place and finetuned the handling a bit as well -
Frank Nägler commented on patch set 11 CR -1 04/08/16, 09:11
AbstractLinkBrowserController.php:315I dislike the implementation. this message can not be localized. I would prefer to use the exception code (timestamp) to localize the message for the FlashMessage. -
Markus Klein commented on patch set 11 CR 0 04/08/16, 09:45
Right Frank. Sorry I totally overlooked that. Lets see if we can improve that. We should try to localize by the exception id, but should fall back to the exception message, if no translation is available. This is important for third party link handlers using this exception. -
Nicole Hummel commented on patch set 11 04/08/16, 10:39
AbstractLinkBrowserController.php:315ReplyHow do you want to resolve a localized exception message if there is an extension involed? Where to get the label from? IMHO this doesn't work as the core would have to deliver the exception message. -
Frank Nägler commented on patch set 11 04/08/16, 11:08
AbstractLinkBrowserController.php:315Replywe talk about the InvalidCurrentLinkException which is introduced in this patch. no other exception is catched here. So I don't see a problem here to use the exception code and translation. -
Markus Klein commented on patch set 11 04/08/16, 19:59
@Nicole: Please see my comment. I would suggest to try to localize via the code, but to fall back to the exception msg, if that is not possible, which is the case for extensions mostly. -
Benni Mack commented on patch set 11 05/03/17, 08:01
No activity here for over a year. Is anybody going to pick this up? Otherwise I will abandon this patch soon. -
Markus Klein commented on patch set 11 05/03/17, 08:30
IMO this still makes sense. Will try to take care. -
Benni Mack commented on patch set 11 11/30/17, 15:42
@markus please abandon if you can't finish it. -
Markus Klein commented on patch set 11 CR -1 12/01/17, 21:27
on it -
Markus Klein uploaded patch set 12 12/01/17, 21:33
-
TYPO3com voted on patch set 12 V -1 12/01/17, 21:33 Completed build in 08s on Fri, 1 Dec, 10:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17159
-
Markus Klein commented on patch set 12 CR -1 12/01/17, 21:34
only rebased so far -
Mathias Schreiber commented on patch set 12 02/04/18, 14:34
Trying to catch up here. The thing that's missing is the possiblity to localize the exception message, correct? If there's more, please put in a central list either here or in the ticket, ping me and I'll finish the job. -
Andreas Kienast commented on patch set 12 CR -2 07/20/18, 08:39
Will take a look at the patch -
Andreas Kienast voted on patch set 12 CR -1 07/21/18, 08:06
-
Andreas Kienast uploaded patch set 13 07/23/18, 06:20
-
TYPO3com voted on patch set 13 V -1 07/23/18, 06:20 Completed build in 13s on Mon, 23 Jul, 08:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25659
-
Andreas Kienast uploaded patch set 14 07/23/18, 06:22
-
TYPO3com voted on patch set 14 V +1 07/23/18, 06:35 Completed build in 12m 52s on Mon, 23 Jul, 08:35 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25660
-
Markus Klein commented on patch set 14 07/23/18, 07:11
InvalidCurrentLinkException.php:20This exception extends LogicException, which is incorrect IMO. If we get an invalid link this is no mistake in programming, but due to changed/wrong data. So this new exception should be a subclass of any RuntimeException -
Markus Klein commented on patch set 15 07/23/18, 07:12
Published edit on patch set 14. -
Markus Klein commented on patch set 15 07/23/18, 07:12
Where is the new exception thrown? -
TYPO3com voted on patch set 15 V +1 07/23/18, 07:25 Completed build in 13m 27s on Mon, 23 Jul, 09:25 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25661
-
Benni Mack abandoned the change 10/27/18, 15:09
1. Patch does not make sense in its current state (also coming from PS1) where we add a new Exception class which is NEVER thrown. 2. The original request by Xavier in the ticket cannot be reproduced anymore by myself. Please provide more information if somebody wants to pick that one up.
LinkBrowserController.php:34