Review main Merged

44893[TASK] Remove unneeded max value check

Adrian von Arx CR +2 V +2 Easy +1 −1 updated 11/22/15, 11:18

Commit message

Use PHP min instead of forceIntegerInRange since no max value is needed

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
    • Sebastian Fischer +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • Sebastian Fischer +1

Issues 1

Files 1

Review log 7

  1. Adrian von Arx uploaded patch set 1 11/22/15, 10:50

  2. Markus Klein commented on patch set 1 CR -1 11/22/15, 10:59

    RecordList.php:406

    This allows to set a negative pointer now
  3. Markus Klein commented on patch set 2 11/22/15, 11:03

    Published edit on patch set 1
  4. Markus Klein voted on patch set 2 CR +1 V +1 11/22/15, 11:03

  5. Sebastian Fischer voted on patch set 2 CR +1 V +1 11/22/15, 11:06

  6. Georg Ringer voted on patch set 2 CR +2 V +2 11/22/15, 11:18

  7. Gerrit merged patch set 2 11/22/15, 11:18