44901[FEATURE] Find image resources in srcset attributes
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2431
Show 6 earlier messages
-
Stefan Neufeind uploaded patch set 1 11/22/15, 13:50
-
Stefan Neufeind commented on patch set 1 11/22/15, 14:10
Also add support for <img srcset="..."> http://www.w3.org/html/wg/drafts/html/master/semantics.html -
Georg Ringer commented on patch set 1 CR -1 11/28/15, 20:02
can you please add a rst file as well? -
Benni Mack commented on patch set 1 03/17/16, 08:15
I consider this a bugfix which should go into 7 as well. Agreed Georg? -
Benni Mack updated the commit message in patch set 2 03/31/16, 17:25
-
Benni Mack voted on patch set 2 CR +1 03/31/16, 17:25
-
Morton Jonuschat uploaded patch set 3 04/01/16, 08:41
-
Morton Jonuschat commented on patch set 3 V -1 04/01/16, 08:43
Added tests, functionality broken if an actual srcset consisting of multiple images is provided - see https://html.spec.whatwg.org/multipage/embedded-content.html#attr-picture-source-srcset for the specs. -
TYPO3com voted on patch set 3 V -1 12/04/16, 11:34 Completed build in 34m 49s on Sun, 4 Dec, 12:34 PM Test Summary: 6 of 54400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5482
-
Morton Jonuschat commented on patch set 3 12/31/16, 04:40
@Stefan: Want to pick this up again or should be abandon this for now? -
Morton Jonuschat abandoned the change 02/16/17, 03:18
No action for close to a year -
Oliver Hader restored the change 06/18/21, 08:04
-
Oliver Hader commented on patch set 3 06/18/21, 08:04
Actually this seems to be a valid change... restored -
Oliver Hader rebased onto patch set 4 06/18/21, 08:04
-
core-ci voted on patch set 4 V -1 06/18/21, 08:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12570
-
Benni Mack updated the commit message in patch set 5 06/21/21, 09:04
-
core-ci voted on patch set 5 V -1 06/21/21, 09:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12616
-
Benni Mack uploaded patch set 6 06/22/21, 11:47
-
Oliver Hader voted on patch set 6 CR +1 06/22/21, 11:49
-
core-ci voted on patch set 6 V -1 06/22/21, 11:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12666
-
Stefan Neufeind commented on patch set 6 CR +1 06/22/21, 11:59
Thanks for picking this change up and taking care. I almost forgot about the change :-) -
Nikita Hovratov uploaded patch set 7 07/27/21, 09:05
-
core-ci voted on patch set 7 V +1 07/27/21, 09:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13795
-
Benni Mack voted on patch set 7 V +1 CR +1 07/29/21, 11:17
-
Christian Kuhn voted on patch set 7 CR -1 07/29/21, 11:25
-
Christian Kuhn uploaded patch set 8 07/29/21, 11:44
-
Christian Kuhn voted on patch set 8 V +1 CR +1 07/29/21, 11:45
-
core-ci voted on patch set 8 V -1 07/29/21, 12:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13875
-
core-ci voted on patch set 8 V +1 07/29/21, 12:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13875
-
Benni Mack voted on patch set 8 V +2 CR +2 07/29/21, 19:21
-
Benni Mack merged patch set 9 07/29/21, 19:21