Review main Merged

44911[BUGFIX] Fix broken unit tests for system with e.g. german locale

Frank Nägler CR +2 V +2 Easy +18 −1 updated 11/23/15, 21:20

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
  • Verified V +2
    • Wouter Wolters +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 16

  1. Frank Nägler uploaded patch set 1 11/23/15, 10:48

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 11/23/15, 10:58

  3. Wouter Wolters commented on patch set 1 CR +1 11/23/15, 11:00

    Not testable on my system for now.
  4. Michael Oehlhof commented on patch set 1 11/23/15, 11:30

    I have testet it on the review box and got this error: PHPUnit_Framework_Exception: The locale functionality is not implemented on your platform, the specified locale does not exist or the category name is invalid. /var/www/review.local.typo3.org/typo3_src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:2142 Settings of the review box are: LANG=en_US.UTF-8 LANGUAGE=en_US: LC_CTYPE="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_PAPER="en_US.UTF-8" LC_NAME="en_US.UTF-8" LC_ADDRESS="en_US.UTF-8" LC_TELEPHONE="en_US.UTF-8" LC_MEASUREMENT="en_US.UTF-8" LC_IDENTIFICATION="en_US.UTF-8" LC_ALL=en_US.UTF-8
  5. Frank Nägler commented on patch set 1 CR -1 11/23/15, 11:50

    not the perfect solution yet, we need another fix
  6. Frank Nägler abandoned the change 11/23/15, 15:11

  7. Frank Nägler restored the change 11/23/15, 15:54

  8. Frank Nägler uploaded patch set 2 11/23/15, 15:55

  9. Michael Oehlhof commented on patch set 2 CR +1 V +1 11/23/15, 16:12

    One little comment, but it is ok if we leave it as it is. Thanks for tanking over the locale problem of the original patch.

    ContentObjectRendererTest.php:2159

    Is this needed? It is already done 3 lines above in the if clause.
  10. Andreas Bouche voted on patch set 2 CR +1 11/23/15, 16:23

  11. Andreas Bouche voted on patch set 2 CR 0 V +1 11/23/15, 16:23

  12. Frank Nägler uploaded patch set 3 11/23/15, 19:23

  13. Frank Nägler commented on patch set 2 11/23/15, 19:24

    ContentObjectRendererTest.php:2159 Reply

    thx, changed
  14. Michael Oehlhof voted on patch set 3 CR +1 V +1 11/23/15, 19:57

  15. Wouter Wolters voted on patch set 3 CR +2 V +2 11/23/15, 21:20

  16. Gerrit merged patch set 3 11/23/15, 21:20