Review main Merged

44927[TASK] Remove leftover FLOW3 code in Caching

Benni Mack CR +2 V +2 Normal +0 −157 updated 11/24/15, 14:10

Commit message

The Caching Framework has still an Exception
related to the (now removed) class loading and some
methods which depend on FLOW3 caches and classes
which were never used.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1

Issues 1

Files 4

Review log 14

  1. Benni Mack uploaded patch set 1 11/24/15, 10:51

  2. Wouter Wolters voted on patch set 1 CR +1 11/24/15, 10:52

  3. Georg Ringer voted on patch set 1 CR +1 V +1 11/24/15, 11:34

  4. Benni Mack commented on patch set 1 CR -2 11/24/15, 11:35

    waiting for helmuts feedback
  5. Helmut Hummel voted on patch set 1 CR +1 V +1 11/24/15, 12:53

  6. Helmut Hummel commented on patch set 1 V -1 11/24/15, 12:55

    There are still tests for the removed methods
  7. Benni Mack uploaded patch set 2 11/24/15, 12:56

  8. Benni Mack voted on patch set 2 CR 0 11/24/15, 12:57

  9. Benni Mack commented on patch set 3 11/24/15, 13:26

    Published edit on patch set 2
  10. Markus Klein voted on patch set 3 CR +1 11/24/15, 13:26

  11. Markus Klein voted on patch set 3 V +1 11/24/15, 13:29

  12. Helmut Hummel voted on patch set 3 CR +2 V +2 11/24/15, 13:48

  13. Gerrit merged patch set 3 11/24/15, 13:50

  14. Christian Kuhn commented on patch set 4 11/24/15, 14:10

    post +1