Review main Merged

44929[TASK] Change APC cache preset condition

Thorsten Bringewatt CR +2 V +2 Easy +5 −9 updated 03/04/16, 11:25

Commit message

This commit removes the check for minimum total apc cache size.
It should be enough to check for at least 5 MB free memory.

Review

  • Code review CR +2
    • Benni Mack +2
    • Alexander Opitz +1
  • Verified V +2
    • Benni Mack +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 16

  1. Thorsten Bringewatt uploaded patch set 1 11/24/15, 13:22

  2. Georg Ringer commented on patch set 1 11/24/15, 13:24

    This is not an feature and surly should not be in 6.2
  3. Mathias Schreiber commented on patch set 2 11/24/15, 13:29

    Published edit on patch set 1
  4. Mathias Schreiber commented on patch set 2 CR -2 11/24/15, 13:30

    As discussed with Phillip already, we will be blocking this for the time being. But we will keep this review (please do NOT abandon it) as a reminder patch.
  5. Benni Mack voted on patch set 2 CR +1 03/03/16, 18:30

  6. Mathias Schreiber voted on patch set 2 CR 0 03/03/16, 19:19

  7. Benni Mack voted on patch set 2 V +1 03/03/16, 19:32

  8. Benni Mack wrote 03/03/16, 19:33

    Patch set 3: Commit message was updated.
  9. Benni Mack voted on patch set 3 CR +1 V +1 03/03/16, 19:33

  10. Wouter Wolters voted on patch set 3 CR +1 03/03/16, 19:37

  11. Benni Mack wrote 03/03/16, 20:00

    Patch set 4: Commit message was updated.
  12. Benni Mack voted on patch set 4 CR +1 V +1 03/03/16, 20:00

  13. Alexander Opitz voted on patch set 4 CR +1 V +1 03/04/16, 11:23

  14. Benni Mack voted on patch set 4 CR +2 V +2 03/04/16, 11:25

  15. Gerrit merged patch set 4 03/04/16, 11:25

  16. Benni Mack commented on patch set 5 03/04/16, 11:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b64825c214914da1586000b8a069f52d237191a2