Review main Merged

44932[TASK] Only instantiate Locales in csConv when necessary

Benni Mack CR +2 V +2 Easy +23 −26 updated 11/25/15, 12:34

Commit message

The locales property inside CharsetConverter is only
used for detecting the browsers' preferred language,
so it does not need to be instantiated on every TYPO3
request.

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 11/24/15, 14:22

  2. Helmut Hummel voted on patch set 1 CR +1 V +1 11/25/15, 11:42

  3. Markus Klein commented on patch set 2 11/25/15, 11:53

    Published edit on patch set 1
  4. Markus Klein commented on patch set 2 CR +1 V +1 11/25/15, 11:54

    Minor improvement only to avoid double array_keys() call and save memory
  5. Helmut Hummel voted on patch set 2 CR +1 V +1 11/25/15, 12:00

  6. Markus Klein voted on patch set 2 CR +2 V +2 11/25/15, 12:34

  7. Gerrit merged patch set 2 11/25/15, 12:34