44946[BUGFIX] EXT:form - bring back "Show message in label"
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Carlos Meyer +1
- Björn Jacob +1
- Andreas Kienast +1
-
Verified V +2
- Morton Jonuschat +2
- Björn Jacob +1
Issues 1
Files 1
Review log 12
-
Ralf Zimmermann uploaded patch set 1 11/26/15, 10:11
-
Björn Jacob voted on patch set 1 CR +1 V +1 11/26/15, 12:46
-
Björn Jacob commented on patch set 1 11/26/15, 12:46
Added example form to issue. -
Björn Jacob commented on patch set 2 11/26/15, 12:47
Published edit on patch set 1 -
Andreas Kienast voted on patch set 1 CR +1 11/26/15, 12:47
-
Björn Jacob voted on patch set 2 CR +1 V +1 11/26/15, 12:47
-
Andreas Kienast voted on patch set 2 CR +1 11/26/15, 14:09
-
Carlos Meyer commented on patch set 2 CR -1 11/26/15, 15:35
With test case, both messages are visible in label tag. -
Björn Jacob commented on patch set 2 11/26/15, 18:48
@Carlos: you're getting it wrong how this functionality worked before. It only hides the message defined via rules.x.message =. The error message was never touched by this attribute (rules.x.error). So please remove your -1 :) -
Carlos Meyer commented on patch set 2 CR +1 11/26/15, 19:12
> With test case, both messages are visible in label tag. Now I understand ;-). This functionality works for me. -
Morton Jonuschat voted on patch set 2 CR +2 V +2 11/27/15, 14:58
-
Gerrit merged patch set 2 11/27/15, 14:58