44955[BUGFIX] EXT:form - accept-charset in form not working
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Björn Jacob +1
-
Verified V +2
- Morton Jonuschat +2
- Björn Jacob +1
Issues 1
Files 5
- typo3/sysext/form/Classes/Domain/Model/Attribute/AcceptCharsetAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AttributesAttribute.php+4 −3
- typo3/sysext/form/Configuration/PageTS/modWizards.ts+2 −2
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Basic/Form.js3+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Attributes.js+3 −3
Review log 11
-
Ralf Zimmermann uploaded patch set 1 11/26/15, 12:44
-
Björn Jacob commented on patch set 2 11/26/15, 14:39
Published edit on patch set 1 -
Björn Jacob commented on patch set 2 CR +1 V +1 11/26/15, 14:42
Tested with the supllied form of Julian (see issue). -
Björn Jacob commented on patch set 1 11/26/15, 14:43
Form.js:75Why is this attribute in " and the others not (besides "class")? -
Ralf Zimmermann commented on patch set 1 11/26/15, 14:57
Form.js:75ReplyJavascript errors if not. The '-' is only a valid character in quoted identifies. -
Björn Jacob commented on patch set 1 11/26/15, 14:58
Form.js:75ReplyDone -
Morton Jonuschat uploaded patch set 3 11/27/15, 15:25
-
Morton Jonuschat voted on patch set 3 CR +1 V +1 11/27/15, 15:45
-
Björn Jacob voted on patch set 3 CR +1 V +1 11/27/15, 15:59
-
Morton Jonuschat voted on patch set 3 CR +2 V +2 11/27/15, 16:09
-
Gerrit merged patch set 3 11/27/15, 16:09