Review TYPO3_6-2 Merged

44955[BUGFIX] EXT:form - accept-charset in form not working

Ralf Zimmermann CR +2 V +2 Easy +11 −10 updated 11/27/15, 16:09

Commit message

Let the wizard write the correct attribute name "accept-charset"
instead of "acceptcharset". Avoid non existing attribute-class loading
if an attribute name contains non-alphabetic characters.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Björn Jacob +1
  • Verified V +2
    • Morton Jonuschat +2
    • Björn Jacob +1

Issues 1

Files 5

Review log 11

  1. Ralf Zimmermann uploaded patch set 1 11/26/15, 12:44

  2. Björn Jacob commented on patch set 2 11/26/15, 14:39

    Published edit on patch set 1
  3. Björn Jacob commented on patch set 2 CR +1 V +1 11/26/15, 14:42

    Tested with the supllied form of Julian (see issue).
  4. Björn Jacob commented on patch set 1 11/26/15, 14:43

    Form.js:75

    Why is this attribute in " and the others not (besides "class")?
  5. Ralf Zimmermann commented on patch set 1 11/26/15, 14:57

    Form.js:75 Reply

    Javascript errors if not. The '-' is only a valid character in quoted identifies.
  6. Björn Jacob commented on patch set 1 11/26/15, 14:58

    Form.js:75 Reply

    Done
  7. Morton Jonuschat uploaded patch set 3 11/27/15, 15:25

  8. Morton Jonuschat voted on patch set 3 CR +1 V +1 11/27/15, 15:45

  9. Björn Jacob voted on patch set 3 CR +1 V +1 11/27/15, 15:59

  10. Morton Jonuschat voted on patch set 3 CR +2 V +2 11/27/15, 16:09

  11. Gerrit merged patch set 3 11/27/15, 16:09