Review main Merged

44964[BUGFIX] Show title in button popup with correct encoding

Michael Oehlhof CR +2 V +2 Easy +23 −20 updated 11/27/15, 18:23

Commit message

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Markus Klein +1
    • Frank Nägler +1
    • Michael Oehlhof +1
  • Verified V +2
    • Morton Jonuschat +2
    • Markus Klein +1
    • Michael Oehlhof +1

Issues 1

Files 3

Review log 10

  1. Michael Oehlhof uploaded patch set 1 11/26/15, 20:04

  2. Markus Klein uploaded patch set 2 11/26/15, 23:09

  3. Markus Klein updated the commit message in patch set 3 11/26/15, 23:10

  4. Markus Klein voted on patch set 3 CR +1 V +1 11/26/15, 23:11

  5. Michael Oehlhof voted on patch set 3 CR +1 V +1 11/26/15, 23:14

  6. Frank Nägler commented on patch set 3 CR -1 11/27/15, 08:59

    please use $lang->sL(key, true) instead of htmlspecialchars($lang->sL(key)) the code is the same, and we use all over the core the second param of sL for hsc. I think the main problem is the removed fundtion makeEntities. Please check this, and don't remove the second parameter of sL. If you have any questions, feel free to contact me directly on slack.

    EditFileController.php:255

    the second param of sL function set to true use htmlspecialcharts, no need to remove the params and call it here directly

    FileSystemNavigationFrameController.php:243

    same here
  7. Frank Nägler commented on patch set 3 CR +1 11/27/15, 09:14

    After talking toi Wouter, he told me the new goal is to get rid of this second parameter to do HSC on lang labels. So I am fine with the patch code wise.
  8. Georg Ringer commented on patch set 3 11/27/15, 09:30

    EditFileController.php:255 Reply

    it is planned to deprecate the 2nd argument of ->sL(), therefore this is fine. official info will be released soon
  9. Morton Jonuschat voted on patch set 3 CR +2 V +2 11/27/15, 18:23

  10. Gerrit merged patch set 3 11/27/15, 18:23