Review main Merged

44977[BUGFIX] Change name of correct pagetree entry after renaming

Martin Gebert CR +2 V +2 Easy +16 −14 updated 12/04/15, 09:42

Commit message

* The first parameter to TreeEditor.complete and
TreeEditor.beforecomplete is the TreeEditor, not the edited node.
Reflect this in the code.
* In TreeEditor.updateNodeText, update the node provided as parameter
instead of the current editNode.
* In saveTitle, remove the first parameter, because it's used in the
wrong way (code assumes i'ts a node, but it's actually a TreeEditor) and
is not necessary.
* In saveTitle, store the current editNode, in case treeEditor.editNode
changes before the ajax call completes.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Michael Oehlhof +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 7

  1. Martin Gebert uploaded patch set 1 11/27/15, 13:13

  2. Michael Oehlhof voted on patch set 1 CR +1 V +1 12/03/15, 21:38

  3. Daniel Goerz commented on patch set 2 12/03/15, 21:52

    Published edit on patch set 1
  4. Daniel Goerz voted on patch set 2 CR +1 V +1 12/03/15, 21:53

  5. Michael Oehlhof voted on patch set 2 CR +1 V +1 12/03/15, 21:59

  6. Andreas Kienast voted on patch set 2 CR +2 V +2 12/04/15, 09:42

  7. Gerrit merged patch set 2 12/04/15, 09:42