Review main Merged

45014[BUGFIX] Prevent double encoding in button rendering

Nicole Hummel CR +2 V +2 Normal +110 −116 updated 11/29/15, 10:55

Commit message

Multiple button settings are double encoded with htmlspecialchars. This
patch removes the hsc within the setters as the button settings are
already escaped during render method.

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1
    • Michael Oehlhof +1

Issues 1

Files 35

Show 15 more files

Review log 7

  1. Nicole Hummel uploaded patch set 1 11/28/15, 14:14

  2. Georg Ringer commented on patch set 2 11/28/15, 19:49

    Published edit on patch set 1
  3. Georg Ringer voted on patch set 2 CR +1 V +1 11/28/15, 19:53

  4. Michael Oehlhof voted on patch set 2 CR +1 V +1 11/29/15, 00:39

  5. Markus Klein commented on patch set 2 CR -1 11/29/15, 10:46

    reviewing
  6. Markus Klein commented on patch set 2 CR +2 V +2 11/29/15, 10:55

    Perfect work. Looked through all buttons again. Thanks.
  7. Gerrit merged patch set 2 11/29/15, 10:55