Review main Merged

45039[BUGFIX] Remove NOT NULL from optional text fields in system extensions

Tomas Norre Mikkelsen CR +2 V +2 Easy +7 −7 updated 12/04/15, 13:08

Commit message

Removes NOT NULL requirement from TEXT database columns where the field is
not required to be filled in the backend. This aligns TCA definition and
database configuration, allowing to skip those fields when creating
records as MySQL doesn't allow default values for TEXT columns.

Review

  • Code review CR +2
    • Benni Mack +2
    • Morton Jonuschat +1
  • Verified V +2
    • Benni Mack +2
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 13

  1. Tomas Norre Mikkelsen uploaded patch set 1 11/29/15, 10:05

  2. Georg Ringer voted on patch set 1 CR +1 V +1 12/01/15, 07:27

  3. Josef Glatz voted on patch set 1 CR +1 12/01/15, 08:44

  4. Tomas Norre Mikkelsen uploaded patch set 2 12/01/15, 13:24

  5. Morton Jonuschat commented on patch set 2 CR -1 12/01/15, 14:16

    Please don' blindly remove NOT NULL, it also ensures data integrity. Also the commit message doesn't reflect the whole change anymore.
  6. Morton Jonuschat commented on patch set 2 12/01/15, 14:17

    ext_tables.sql:337

    A backend layout without config doesn't work, so the NOT NULL is actually good here.
  7. Tomas Norre Mikkelsen uploaded patch set 3 12/01/15, 17:30

  8. Tomas Norre Mikkelsen uploaded patch set 4 12/01/15, 17:35

  9. Morton Jonuschat commented on patch set 4 CR -1 12/04/15, 12:43

    On it
  10. Morton Jonuschat updated the commit message in patch set 5 12/04/15, 13:02

  11. Morton Jonuschat voted on patch set 5 CR +1 V +1 12/04/15, 13:02

  12. Benni Mack voted on patch set 5 CR +2 V +2 12/04/15, 13:08

  13. Gerrit merged patch set 5 12/04/15, 13:08