Review main Abandoned

45046[BUGFIX] Detect the right PHP version

Nicole Hummel CR 0 V 0 Easy +16 −2 updated 12/18/15, 12:51

Commit message

Currently the official releases from PHP7 are not handled correctly
within the installation process. This patch improves the detection of
the PHP version by stripping suffixes like "-dev" or "RC".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 19

  1. Nicole Hummel uploaded patch set 1 11/29/15, 11:26

  2. Matthias Vogel voted on patch set 1 CR +1 11/29/15, 11:28

  3. Wouter Wolters commented on patch set 1 CR -1 11/29/15, 12:35

    please apply psr-2 for the function
  4. Markus Klein commented on patch set 2 11/29/15, 12:40

    Published edit on patch set 1
  5. Markus Klein commented on patch set 2 11/29/15, 12:41

    * fixed psr-2 * fiexed phpdoc * streamlined the regex a bit Note: the version number will always start with a number anyways, so no need to check that with the regex, furthermore a non-capturing group is better.
  6. Nicole Hummel commented on patch set 2 11/29/15, 12:46

    Check.php:1563

    Why do we need an empty line here?
  7. Markus Klein commented on patch set 2 11/29/15, 13:04

    Check.php:1563 Reply

    Of course! See phpdoc specification title of method <empty line> paragraph <empty line> paragraph ...
  8. Markus Klein commented on patch set 3 11/29/15, 13:06

    Published edit on patch set 2
  9. Markus Klein voted on patch set 3 CR +1 11/29/15, 13:14

  10. Benni Mack commented on patch set 3 CR -1 11/29/15, 21:26

    Check.php:495

    can be done simpler: a) just use $maximumPhpVersion = '7.0' and it works as expected. b) we wait until december 3rd and the problem is solved :)
  11. Alexander Opitz commented on patch set 3 12/01/15, 10:07

    What happens if 7.0.1 gets released, if 7.0.0 is maximum?
  12. Benni Mack commented on patch set 3 12/01/15, 10:10

    Alex, always_populate_raw_post_data is removed in PHP 7.0RC1 and removed in PHP 7.0.0 and PHP 7.0.1 - checking for "7.0" as maximum version works across all versions.
  13. Alexander Opitz commented on patch set 3 CR +1 V +1 12/01/15, 10:14

    *bam* Ok, misread for what this is, thought it checks to Version to tell if TYPO3 works with it or not. ;) So, I would like to let the code as is, we may use this later on for other things.
  14. Morton Jonuschat commented on patch set 3 12/02/15, 19:28

    I like Bennis approach with the 7.0 instead of 7.0.0, feels more elegant
  15. Michael Oehlhof voted on patch set 3 CR +1 V +1 12/03/15, 13:39

  16. Benni Mack commented on patch set 3 12/04/15, 22:28

    ok. did anybody try a new installation with php 7 final and still have that problem?
  17. Alexander Opitz commented on patch set 3 12/17/15, 12:34

    In https://forge.typo3.org/issues/71568 Marcus Schwemer wrote that this is solved with PHP 7.0.0
  18. Benni Mack commented on patch set 3 12/17/15, 15:55

    @Nicole: OK to abandon this one?
  19. Nicole Hummel abandoned the change 12/18/15, 12:51

    Solved with PHP 7 release