45049[TASK] EXT:lang CodeCleanup
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2
- Markus Klein +2
- Benni Mack +1
Issues 1
Files 12
- typo3/sysext/lang/Classes/Command/LanguageCommandController.php+13 −7
- typo3/sysext/lang/Classes/Controller/LanguageController.php1+12 −4
- typo3/sysext/lang/Classes/Domain/Model/Extension.php+5 −2
- typo3/sysext/lang/Classes/Domain/Model/Language.php+3 −1
- typo3/sysext/lang/Classes/Domain/Repository/ExtensionRepository.php+7 −4
- typo3/sysext/lang/Classes/Domain/Repository/LanguageRepository.php+22 −7
- typo3/sysext/lang/Classes/Service/RegistryService.php+3 −1
- typo3/sysext/lang/Classes/Service/TerService.php1+15 −10
- typo3/sysext/lang/Classes/Service/TranslationService.php+11 −5
- typo3/sysext/lang/Classes/View/Language/GetTranslationsJson.php1+2 −0
- typo3/sysext/lang/Classes/View/AbstractJsonView.php+7 −3
- typo3/sysext/lang/Classes/LanguageService.php+4 −2
Review log 14
-
Michael Oehlhof uploaded patch set 1 11/29/15, 11:48
-
Georg Ringer commented on patch set 1 11/30/15, 07:19
-
Georg Ringer voted on patch set 1 CR -1 11/30/15, 07:19
-
Michael Oehlhof commented on patch set 2 11/30/15, 11:02
Published edit on patch set 1 -
Michael Oehlhof uploaded patch set 3 12/06/15, 23:30
-
Georg Ringer voted on patch set 3 CR -1 12/07/15, 11:37
-
Michael Oehlhof commented on patch set 3 12/07/15, 11:46
Any reason for the -1? -
Benni Mack voted on patch set 3 CR +1 V +1 12/23/15, 15:46
-
Markus Klein commented on patch set 3 12/23/15, 18:38
TerService.php:94why do we need that?GetTranslationsJson.php:32do we have a more precise type information here? -
Benni Mack uploaded patch set 4 01/08/16, 13:28
-
Benni Mack voted on patch set 4 CR +1 V +1 01/08/16, 13:29
-
Wouter Wolters voted on patch set 4 CR +1 01/08/16, 13:47
-
Markus Klein voted on patch set 4 CR +2 V +2 01/08/16, 18:30
-
Gerrit merged patch set 4 01/08/16, 18:30
LanguageController.php:154