Review main Merged

45049[TASK] EXT:lang CodeCleanup

Michael Oehlhof CR +2 V +2 Normal +104 −46 updated 01/08/16, 18:30

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1

Issues 1

Files 12

Review log 14

  1. Michael Oehlhof uploaded patch set 1 11/29/15, 11:48

  2. Georg Ringer commented on patch set 1 11/30/15, 07:19

    LanguageController.php:154

    so clean this namespace up as well pls
  3. Georg Ringer voted on patch set 1 CR -1 11/30/15, 07:19

  4. Michael Oehlhof commented on patch set 2 11/30/15, 11:02

    Published edit on patch set 1
  5. Michael Oehlhof uploaded patch set 3 12/06/15, 23:30

  6. Georg Ringer voted on patch set 3 CR -1 12/07/15, 11:37

  7. Michael Oehlhof commented on patch set 3 12/07/15, 11:46

    Any reason for the -1?
  8. Benni Mack voted on patch set 3 CR +1 V +1 12/23/15, 15:46

  9. Markus Klein commented on patch set 3 12/23/15, 18:38

    TerService.php:94

    why do we need that?

    GetTranslationsJson.php:32

    do we have a more precise type information here?
  10. Benni Mack uploaded patch set 4 01/08/16, 13:28

  11. Benni Mack voted on patch set 4 CR +1 V +1 01/08/16, 13:29

  12. Wouter Wolters voted on patch set 4 CR +1 01/08/16, 13:47

  13. Markus Klein voted on patch set 4 CR +2 V +2 01/08/16, 18:30

  14. Gerrit merged patch set 4 01/08/16, 18:30