Review main Merged

45061[TASK] Optimize backend checkboxes check / uncheck all

Frank Nägler CR +2 V +2 Normal +46 −15 updated 12/03/15, 10:54

Commit message

This patch optimises the handling of SelectCheckBoxElements.
The checkbox also shows a tooltip now.

Review

  • Code review CR +2
    • Markus Klein +2
    • Morton Jonuschat +1
  • Verified V +2
    • Markus Klein +2
    • Morton Jonuschat +1

Issues 1

Files 2

Review log 20

  1. Frank Nägler uploaded patch set 1 11/30/15, 13:04

  2. Morton Jonuschat voted on patch set 1 CR +1 11/30/15, 19:48

  3. Frank Nägler uploaded patch set 2 11/30/15, 21:34

  4. Frank Nägler commented on patch set 2 CR -2 11/30/15, 23:07

    not ready yet
  5. Frank Nägler uploaded patch set 3 12/02/15, 20:53

  6. Frank Nägler voted on patch set 3 CR 0 12/02/15, 20:53

  7. Markus Klein uploaded patch set 4 12/02/15, 20:59

  8. Markus Klein commented on patch set 4 V -1 12/02/15, 21:05

    wrong tooltip label and reset button does not toggle the toggle-all-checkbox
  9. Frank Nägler uploaded patch set 5 12/02/15, 21:53

  10. Markus Klein uploaded patch set 6 12/02/15, 22:12

  11. Markus Klein voted on patch set 6 CR +1 V +1 12/02/15, 22:13

  12. Morton Jonuschat commented on patch set 6 CR -1 12/02/15, 22:28

    After clicking the toggle all checkbox the tooltip is fixed and won't be hidden on mouseout / end of hover.
  13. Markus Klein voted on patch set 6 CR 0 V 0 12/02/15, 22:46

  14. Frank Nägler commented on patch set 6 12/02/15, 22:59

    clicking anywhere outside of the checkbox will the tooltip be disappear. I think this a bootstrap issue, we should ignore this.
  15. Stephan Großberndt commented on patch set 7 12/03/15, 01:19

    Published edit on patch set 6
  16. Stephan Großberndt commented on patch set 7 CR -1 12/03/15, 01:20

    only updated commit message, mortons vote still valid
  17. Morton Jonuschat uploaded patch set 8 12/03/15, 06:55

  18. Morton Jonuschat voted on patch set 8 CR +1 V +1 12/03/15, 06:55

  19. Markus Klein voted on patch set 8 CR +2 V +2 12/03/15, 10:53

  20. Gerrit merged patch set 8 12/03/15, 10:54