Review main Merged

45090[BUGFIX] Only show search on non-empty pages

Andreas Kienast CR +2 V +2 Easy +29 −8 updated 12/03/15, 23:23

Commit message

If a page has neither content nor subpages, do not show the search button
in the backend.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 11

  1. Andreas Kienast uploaded patch set 1 12/02/15, 14:46

  2. Markus Klein voted on patch set 1 CR +1 12/02/15, 19:42

  3. Richard Haeser voted on patch set 1 CR +1 12/02/15, 19:58

  4. Andreas Kienast commented on patch set 1 V -1 12/03/15, 07:57

    Does not work in PageLayoutController if page is empty but has subpages.
  5. Andreas Kienast uploaded patch set 2 12/03/15, 08:19

  6. Andreas Kienast commented on patch set 3 12/03/15, 08:20

    Published edit on patch set 2
  7. Markus Klein voted on patch set 3 CR +1 12/03/15, 11:34

  8. Michael Oehlhof voted on patch set 3 CR +1 V +1 12/03/15, 19:42

  9. Daniel Goerz voted on patch set 3 CR +1 V +1 12/03/15, 21:21

  10. Markus Klein voted on patch set 3 CR +2 V +2 12/03/15, 23:23

  11. Gerrit merged patch set 3 12/03/15, 23:23