Review main Merged

45093[BUGFIX] Catch security exceptions in global JS module

Markus Klein CR +2 V +2 Easy +18 −11 updated 12/04/15, 10:13

Commit message

The storage JS module is loaded in the top window.
In case this windows has been opened by some other page
(different domain) then a security exception is thrown
by the browsers, which kills the execution.

Catch exceptions when accessing the opener to avoid
this particular edge case.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Eckard Gehrke +1
  • Verified V +2
    • Andreas Kienast +2
    • Eckard Gehrke +1

Issues 1

Files 1

Review log 7

  1. Markus Klein uploaded patch set 1 12/02/15, 15:39

  2. Eckard Gehrke commented on patch set 1 CR +1 V +1 12/02/15, 21:23

    Tested it with browser IE, Chrome and Firefox. Works very well, error fixed
  3. Wouter Wolters voted on patch set 1 CR +1 12/03/15, 08:22

  4. Andreas Kienast voted on patch set 1 CR +1 12/03/15, 08:31

  5. Daniel Goerz voted on patch set 1 CR +1 12/03/15, 21:34

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 12/04/15, 10:13

  7. Gerrit merged patch set 1 12/04/15, 10:13