45126[BUGFIX] Determine returnUrl when deleting pages in EditDocumentController
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
- Morton Jonuschat +1
-
Verified V +2
- Georg Ringer +2
- Morton Jonuschat +1
Issues 3
Files 1
Review log 19
-
Andreas Kienast uploaded patch set 1 12/04/15, 11:18
-
Andreas Kienast commented on patch set 2 12/04/15, 11:18
Published edit on patch set 1 -
Wouter Wolters commented on patch set 2 CR -2 12/04/15, 11:21
hold on here -
Andreas Kienast commented on patch set 2 CR -1 V -1 12/04/15, 11:24
We need another solution here, see https://review.typo3.org/#/c/44708/ -
Morton Jonuschat uploaded patch set 3 12/07/15, 20:13
-
Morton Jonuschat uploaded patch set 4 12/07/15, 20:21
-
Wouter Wolters voted on patch set 4 CR 0 12/07/15, 20:22
-
Andreas Kienast commented on patch set 4 12/07/15, 21:03
Can we walk up the rootline and use the first available parent instead of calling id 0 instead? Also we should use the module defined in the returnUrl instead hardcoding web_layout, imo. -
Morton Jonuschat commented on patch set 4 12/07/15, 21:12
Using the next page up in rootline has the problem that the tree doesn't reflect the shown page anymore. The behavior with id=0 is the same as it has been before deleting pages from EditDocumentController broke. The web_layout module isn't really hardcoded as it's wrapped in an if condition that checks for exactly that module (since it's the only one needing special handling). I can switch it to using the "M" query param but I didn't see any value in that. -
Andreas Kienast uploaded patch set 5 12/09/15, 16:39
-
Andreas Kienast commented on patch set 5 12/09/15, 16:39
another approach :) -
Andreas Kienast commented on patch set 5 CR -1 V -1 12/09/15, 16:42
Still meh -
Andreas Kienast uploaded patch set 6 12/09/15, 19:49
-
Andreas Kienast uploaded patch set 7 12/09/15, 19:50
-
Morton Jonuschat uploaded patch set 8 12/09/15, 20:06
-
Morton Jonuschat voted on patch set 8 CR +1 V +1 12/09/15, 20:07
-
Wouter Wolters voted on patch set 8 CR +1 12/09/15, 22:24
-
Georg Ringer voted on patch set 8 CR +2 V +2 12/10/15, 04:49
-
Gerrit merged patch set 8 12/10/15, 04:49