Review main Merged

45141[BUGFIX] Use "id" attribute for HMENU images in HTML5

Benni Mack CR +2 V +2 Easy +4 −1 updated 12/06/15, 11:59

Commit message

When setting no config.doktype=html5, then the TYPO3
Frontend renders everything as HTML5, except for
the "name" attribute for before/after logic of HMENUs,
which should use "id" attributes.

The "default" option needs to be taken into account
in order to use "id" instead of "name".

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • Georg Ringer +1

Issues 1

Files 1

Review log 6

  1. Benni Mack uploaded patch set 1 12/05/15, 13:07

  2. Wouter Wolters voted on patch set 1 CR +1 12/05/15, 15:30

  3. Georg Ringer voted on patch set 1 CR +1 V +1 12/05/15, 20:30

  4. Daniel Goerz voted on patch set 1 CR +1 V +1 12/05/15, 21:56

  5. Jigal van Hemert voted on patch set 1 CR +2 V +2 12/06/15, 11:59

  6. Gerrit merged patch set 1 12/06/15, 11:59