Review main Merged

45145[BUGFIX] Let FormEngine Slider wizard save data again

Benni Mack CR +2 V +2 Easy +2 −2 updated 12/06/15, 12:02

Commit message

Due to a change in FormEngine slider rewrite, the parameters
do not get handed over to the TBE_EDITOR update signal,
thus any changes on the slider do not reflect the actual field
that is sent to the server again.

Using apply() correctly as well as a document.ready()
statement makes this functionality work again.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Benni Mack uploaded patch set 1 12/05/15, 15:06

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 12/05/15, 15:28

  3. Daniel Goerz voted on patch set 1 CR +1 V +1 12/05/15, 21:59

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 12/06/15, 12:02

  5. Gerrit merged patch set 1 12/06/15, 12:02