Review main Merged

45147[BUGFIX] DebuggerUtility should return css when requested.

Benni Mack CR +2 V +2 Easy +4 −3 updated 12/06/15, 19:36

Commit message

The DebuggerUtility of Extbase should only echo the CSS when
the debug info is echoed as well, otherwise it should be
returned just like the option describes it.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Jigal van Hemert +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 10

  1. Benni Mack uploaded patch set 1 12/05/15, 15:13

  2. Markus Klein commented on patch set 1 CR +1 12/05/15, 15:20

    If I'm not mistaken we had a similar change somewhere
  3. Wouter Wolters voted on patch set 1 CR +1 12/05/15, 15:28

  4. Markus Klein commented on patch set 1 CR 0 12/05/15, 15:32

    I have to look at this in detail. I want to find the old change, which did something here too.
  5. Andreas Kienast commented on patch set 1 12/06/15, 12:10

    Markus, do you mean my abandoned change? https://review.typo3.org/#/c/38046/
  6. Markus Klein commented on patch set 1 CR +1 12/06/15, 14:00

    Yes, that's the one. Thanks. All good
  7. Jigal van Hemert voted on patch set 1 CR +1 12/06/15, 15:25

  8. Frank Nägler voted on patch set 1 CR +1 V +1 12/06/15, 18:17

  9. Jigal van Hemert voted on patch set 1 CR +2 V +2 12/06/15, 19:36

  10. Gerrit merged patch set 1 12/06/15, 19:36