45157[TASK] Allow calling tests with phpdbg-SAPI
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Andreas Wolf +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Benni Mack +1
Issues 1
Files 2
Review log 14
-
Stefan Neufeind uploaded patch set 1 12/06/15, 13:49
-
Stefan Neufeind commented on patch set 1 12/06/15, 13:49
phpunit-call: https://thephp.cc/news/2015/08/phpunit-4-8-code-coverage-support benchmark: http://blog.remirepo.net/post/2015/11/09/PHPUnit-code-coverage-benchmark -
Georg Ringer voted on patch set 1 CR +1 V +1 12/07/15, 06:01
-
Andreas Kienast commented on patch set 1 12/07/15, 08:42
FunctionalTestsBootstrap.php:141braces are not required.UnitTestsBootstrap.php:232braces are not required -
Stefan Neufeind commented on patch set 1 01/19/16, 15:50
with or without brances I don't mind ... yes, we could leave them out. Might this potentially also be interesting for 7.6? Haven't played around with it much yet but ... -
Benni Mack wrote 01/20/16, 15:15
Patch set 2: Published edit on patch set 1. -
Benni Mack uploaded patch set 3 03/05/16, 19:33
-
Benni Mack commented on patch set 3 03/05/16, 19:34
I did not see any activity since over a year in that project and including this in a PHP7-only master version does not make sense to me at this point. I'm for abandoning this patch. -
Benni Mack commented on patch set 3 03/05/16, 21:09
compiling php7 with phpdbg-SAPI now... -
Benni Mack commented on patch set 3 CR +1 V +1 03/05/16, 21:26
fine with me, tests don't run for me, but I think it's a good addition. -
Oliver Hader voted on patch set 3 CR +1 03/06/16, 01:08
-
Andreas Wolf voted on patch set 3 CR +2 03/06/16, 01:09
-
Christian Kuhn voted on patch set 3 CR +2 V +2 03/06/16, 09:44
-
Gerrit merged patch set 3 03/06/16, 09:44