Review main Merged

45160[BUGFIX] Make ToggleExtensionInstallationStateViewHelper PHP 7 compliant

Michael Oehlhof CR +2 V +2 Easy +24 −5 updated 12/11/15, 20:07

Commit message

Match the declaration of the render function with the function
declaration of the base class.

In addition cleanup some code.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
    • Frans Saris +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1
    • Frans Saris +1

Issues 1

Files 1

Review log 10

  1. Michael Oehlhof uploaded patch set 1 12/06/15, 23:18

  2. Jan Helke voted on patch set 1 CR +1 V +1 12/07/15, 14:32

  3. Markus Klein commented on patch set 2 12/08/15, 00:06

    Published edit on patch set 1
  4. Markus Klein commented on patch set 2 CR +1 12/08/15, 00:07

    Updated the commit message to have correct tense
  5. Steffen Müller commented on patch set 2 12/08/15, 10:14

    ToggleExtensionInstallationStateViewHelper.php:35

    $extension is in fact used as an array in the method body, so the annotation should be: @param array $extension Would that break the compatibility with its ancestor and lead to the same error we aim to fix?
  6. Markus Klein uploaded patch set 3 12/10/15, 22:39

  7. Markus Klein voted on patch set 3 CR +1 V +1 12/10/15, 22:39

  8. Frans Saris commented on patch set 3 CR +1 V +1 12/11/15, 07:42

    Works on PHP 5.5 Did someone already test this on PHP 7?
  9. Andreas Kienast voted on patch set 3 CR +2 V +2 12/11/15, 20:07

  10. Gerrit merged patch set 3 12/11/15, 20:07