Review main Merged

45184[BUGFIX] Fix sorting by extension name

Patrick Schriner CR +2 V +2 Easy +35 −4 updated 12/12/15, 19:13

Commit message

Introduce a custom column sort for the "Extension" (name) column as that
column can contain HTML which breaks a direct string comparison.

The existing ExtensionManager.compare function is renamed to
versionCompare to circumvent misunderstandings.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 12

  1. Patrick Schriner uploaded patch set 1 12/08/15, 11:22

  2. Patrick Schriner uploaded patch set 2 12/08/15, 11:23

  3. Patrick Schriner commented on patch set 3 12/08/15, 14:00

    Published edit on patch set 2
  4. Michael Oehlhof voted on patch set 3 CR +1 V +1 12/08/15, 21:52

  5. Wouter Wolters voted on patch set 3 CR +1 12/09/15, 22:24

  6. Josef Glatz voted on patch set 3 CR +1 V +1 12/10/15, 05:05

  7. Gianluigi Martino commented on patch set 3 CR +1 V +1 12/10/15, 09:34

    it works, but it would be nice to have arrows so it is visible wich column is sortable
  8. Patrick Schriner commented on patch set 3 12/10/15, 09:45

    > it works, but it would be nice to have arrows so it is visible wich > column is sortable Absolutely. I have no idea, why this isn't done yet. https://forge.typo3.org/issues/55794 is a tiny indication on the "why"
  9. Morton Jonuschat commented on patch set 3 12/11/15, 08:47

    As TYPO3 6.2 LTS is in priority bugfix mode only I'd only fix this in master
  10. Georg Ringer commented on patch set 4 12/12/15, 19:13

    Published edit on patch set 3
  11. Georg Ringer commented on patch set 4 CR +2 V +2 12/12/15, 19:13

    master only
  12. Gerrit merged patch set 4 12/12/15, 19:13