Review main Merged

45191[BUGFIX] Move default avatar image from background css to img tag

Michael Oehlhof CR +2 V +2 Easy +10 −11 updated 12/10/15, 04:49

Commit message

If a transparent avatar image is assigned the default avatar no longer
shines through.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Frans Saris +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1

Issues 1

Files 4

Review log 8

  1. Michael Oehlhof uploaded patch set 1 12/08/15, 23:52

  2. Frans Saris commented on patch set 1 12/09/15, 07:53

    Avatar.php:64

    Any special reason for placing the check here instead of in getImgTag() ?
  3. Andreas Kienast uploaded patch set 2 12/09/15, 20:24

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 12/09/15, 20:24

  5. Frans Saris voted on patch set 2 CR +1 12/09/15, 20:47

  6. Wouter Wolters voted on patch set 2 CR +1 12/09/15, 22:10

  7. Georg Ringer voted on patch set 2 CR +2 V +2 12/10/15, 04:48

  8. Gerrit merged patch set 2 12/10/15, 04:49