Review main Merged

45202[TASK] Configuration: Make searchbox clearable and fix scroll position

Josef Glatz CR +2 V +2 Easy +39 −0 updated 12/11/15, 05:42

Commit message

This patches ensures the page is scrolled to the right position
upon opening a subtree.
Additionally, the "clear search" button is added to the search field.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Markus Klein +1

Issues 1

Files 2

Review log 8

  1. Josef Glatz uploaded patch set 1 12/10/15, 18:17

  2. Markus Klein commented on patch set 1 12/10/15, 18:54

    ConfigurationView.js:33

    A comment would be nice, what this does
  3. Josef Glatz uploaded patch set 2 12/10/15, 19:49

  4. Markus Klein commented on patch set 3 12/10/15, 22:28

    Published edit on patch set 2
  5. Markus Klein voted on patch set 3 CR +1 V +1 12/10/15, 22:28

  6. Daniel Goerz voted on patch set 3 CR +1 V +1 12/10/15, 23:02

  7. Georg Ringer voted on patch set 3 CR +2 V +2 12/11/15, 05:41

  8. Gerrit merged patch set 3 12/11/15, 05:42