45208[BUGFIX] Set default value for list_type
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Daniel Goerz +1
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Daniel Goerz +1
- Markus Klein +1
Issues 2
Files 1
Review log 12
-
Marco Huber uploaded patch set 1 12/11/15, 11:09
-
Marco Huber commented on patch set 1 12/11/15, 11:11
I'm not sure, if we need a migration script or a breaking change for this or for #32209 -
Markus Klein commented on patch set 1 12/11/15, 11:23
The commit message is a bug description. Please adjust the message to describe the change. -
Marco Huber updated the commit message in patch set 2 12/11/15, 11:55
-
Markus Klein commented on patch set 2 CR +1 12/11/15, 15:11
thanks. Problem is, DB changes usually are never rolled out into released versions. I push this patch for discussion into the product team. -
Christian Kuhn commented on patch set 2 12/11/15, 16:44
history: list_type was used with integers - probably still can be seen with tt_news where eg. "list" display was 6 (guess). that is where this comes from. The default change is probably ok, but should get some testing. Imho, this change would be "okish" to accept in 7 in current this phase of 7.6 lifetime, but clear -1 from me for 6.2 db changes at this late point in 6.2 lifetime should only be done if really really really necessary - i'd rather revert the offending patch from issue #32209 instead in 6.2! further opinions? -
Daniel Goerz voted on patch set 2 CR +1 12/12/15, 20:42
-
Markus Klein commented on patch set 3 12/12/15, 21:31
Published edit on patch set 2 -
Markus Klein commented on patch set 3 CR +1 V +1 12/12/15, 21:31
For 6.2 we either revert the original fix, or, what I would suggest, leave things as they are, since the TCA default is already correct. -
Daniel Goerz voted on patch set 3 CR +1 V +1 12/12/15, 21:44
-
Christian Kuhn commented on patch set 3 CR +2 V +2 12/14/15, 15:45
aligned with markus: merge to 7, but no further change in 6.2 since the bug fix from the related issue is more important than this default change which probably has no further side effects if not done in 6.2 -
Gerrit merged patch set 3 12/14/15, 15:45