Review main Merged

45216[FOLLOWUP][BUGFIX] Wrong overloading of AbstractController::redirect()

Morton Jonuschat CR +2 V +2 Easy +15 −4 updated 12/12/15, 21:27

Commit message

This patch adds the missing parameters for the redirect method so that
the method signature matches between BackendModuleController and
AbstractController. As the parameters are all optional this is a
non-breaking change.

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1

Issues 2

Files 1

Review log 7

  1. Morton Jonuschat uploaded patch set 1 12/11/15, 19:50

  2. Morton Jonuschat uploaded patch set 2 12/11/15, 21:02

  3. Markus Klein commented on patch set 2 12/12/15, 18:58

    BackendModuleController.php:105

    remove those two comments now?
  4. Georg Ringer uploaded patch set 3 12/12/15, 20:37

  5. Georg Ringer voted on patch set 3 CR +1 V +1 12/12/15, 20:38

  6. Markus Klein voted on patch set 3 CR +2 V +2 12/12/15, 21:27

  7. Gerrit merged patch set 3 12/12/15, 21:27