Review main Merged

45217[BUGFIX] ExtensionManager: Make viewhelpers compatible with PHP 7.0

Morton Jonuschat CR +2 V +2 Normal +123 −49 updated 12/14/15, 17:06

Commit message

This patch changes viewhelpers that inherit from the fluid
ActionViewHelper but have a different method signature for render() to
inherit from a base viewhelper that doesn't have a default render()
method, removing the incompatibilities.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Alexander Opitz +2
    • Markus Klein +1

Issues 1

Files 9

Review log 14

  1. Morton Jonuschat uploaded patch set 1 12/11/15, 20:40

  2. Morton Jonuschat uploaded patch set 2 12/11/15, 20:43

  3. Morton Jonuschat commented on patch set 2 CR -1 12/11/15, 20:47

    Still meh, DownloadExtensionViewHelper needs adjustments too
  4. Morton Jonuschat uploaded patch set 3 12/11/15, 20:57

  5. Andreas Kienast voted on patch set 3 CR +1 V +1 12/11/15, 21:20

  6. Markus Klein voted on patch set 3 CR +1 12/12/15, 18:57

  7. Daniel Goerz voted on patch set 3 CR +1 12/12/15, 19:13

  8. Wouter Wolters commented on patch set 3 CR -1 12/13/15, 14:43

    DownloadExtensionViewHelper.php:37

    No @inject anymore please
  9. Markus Klein commented on patch set 3 CR -1 12/13/15, 23:38

    good catch Wouter, as always.
  10. Morton Jonuschat uploaded patch set 4 12/14/15, 16:51

  11. Markus Klein voted on patch set 4 CR +1 V +1 12/14/15, 16:56

  12. Andreas Kienast voted on patch set 4 CR +1 12/14/15, 16:56

  13. Alexander Opitz voted on patch set 4 CR +2 V +2 12/14/15, 17:06

  14. Gerrit merged patch set 4 12/14/15, 17:06