45217[BUGFIX] ExtensionManager: Make viewhelpers compatible with PHP 7.0
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2
- Alexander Opitz +2
- Markus Klein +1
Issues 1
Files 9
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Link/ActionViewHelper.phpnew+43 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConfigureExtensionViewHelper.php+4 −8
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionDataViewHelper.php+1 −6
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php1+69 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ProcessAvailableActionsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+1 −6
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ShowExtensionVersionsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+2 −19
- typo3/sysext/extensionmanager/Classes/ViewHelpers/UpdateScriptViewHelper.php+1 −6
Review log 14
-
Morton Jonuschat uploaded patch set 1 12/11/15, 20:40
-
Morton Jonuschat uploaded patch set 2 12/11/15, 20:43
-
Morton Jonuschat commented on patch set 2 CR -1 12/11/15, 20:47
Still meh, DownloadExtensionViewHelper needs adjustments too -
Morton Jonuschat uploaded patch set 3 12/11/15, 20:57
-
Andreas Kienast voted on patch set 3 CR +1 V +1 12/11/15, 21:20
-
Markus Klein voted on patch set 3 CR +1 12/12/15, 18:57
-
Daniel Goerz voted on patch set 3 CR +1 12/12/15, 19:13
-
Wouter Wolters commented on patch set 3 CR -1 12/13/15, 14:43
DownloadExtensionViewHelper.php:37No @inject anymore please -
Markus Klein commented on patch set 3 CR -1 12/13/15, 23:38
good catch Wouter, as always. -
Morton Jonuschat uploaded patch set 4 12/14/15, 16:51
-
Markus Klein voted on patch set 4 CR +1 V +1 12/14/15, 16:56
-
Andreas Kienast voted on patch set 4 CR +1 12/14/15, 16:56
-
Alexander Opitz voted on patch set 4 CR +2 V +2 12/14/15, 17:06
-
Gerrit merged patch set 4 12/14/15, 17:06