Review main Merged

45218[TASK] Support \DateTimeInterface in fluid Format\DateViewHelper

Morton Jonuschat CR +2 V +2 Easy +14 −5 updated 12/12/15, 21:24

Commit message

This patch changes the fluid DateViewHelper to check for date objects
implementing \DateTimeInterface so that \DateTime as well as
\DateTimeImmutable can be supplied as parameter.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Georg Ringer +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Georg Ringer +1

Issues 1

Files 2

Review log 6

  1. Morton Jonuschat uploaded patch set 1 12/11/15, 21:41

  2. Markus Klein voted on patch set 1 CR +1 12/12/15, 18:50

  3. Georg Ringer voted on patch set 1 CR +1 V +1 12/12/15, 19:05

  4. Daniel Goerz voted on patch set 1 CR +1 V +1 12/12/15, 19:11

  5. Markus Klein voted on patch set 1 CR +2 V +2 12/12/15, 21:24

  6. Gerrit merged patch set 1 12/12/15, 21:24