Review main Merged

45238[BUGFIX] Extend Lowlevel lost_files to accept customPath

Tomas Norre Mikkelsen CR +2 V +2 Easy +33 −7 updated 08/09/17, 06:50

Commit message

This allows the lowlevel lost_files cleaner to use
customPaths as input too.

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Rotsch +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2831

Show 6 earlier messages
  1. Tomas Norre Mikkelsen uploaded patch set 1 12/14/15, 14:18

  2. Erik Frister commented on patch set 1 CR -1 01/05/16, 10:13

    Please check the comments in the review

    LostFilesCommand.php:34

    Maybe it makes sense to mention that it will use /uploads by default if --customPaths are not specified. Additionally, the task now takes two parameters: --excludePath --customPaths Both take csv lists, but one is singular, one is plural. It probably makes sense to rename --customPaths to --customPath to stay consistent

    LostFilesCommand.php:89

    CGL Violation. Should be "true" rather than "TRUE". PSR-2

    LostFilesCommand.php:91

    false rather than FALSE.
  3. Tomas Norre Mikkelsen uploaded patch set 2 01/05/16, 12:18

  4. Erik Frister commented on patch set 2 CR -1 01/05/16, 12:56

    LostFilesCommand.php:34

    Needs to be mentioned that the default path is /uploads. That is not obvious.

    LostFilesCommand.php:36

    customPaths is still used in the help. Please adjust.
  5. Tomas Norre Mikkelsen uploaded patch set 3 01/05/16, 13:04

  6. Irene Höppner commented on patch set 3 CR +1 01/08/16, 15:01

    Looks good for me.
    I would like to have this a little less technical like "Add the possibility to add custom paths to the low level lost_files command" (but shorter than this)
  1. Tomas Norre Mikkelsen uploaded patch set 4 03/07/16, 15:13

  2. Benni Mack commented on patch set 4 03/28/17, 09:09

    Hey tomas, you want to pick that up now that we're all up and running with Symfony Console? Also, I consider this a bugfix or task, because the current behaviour can be harmful if no subfolder etc. can be specified. no "feature".
  3. Tomas Norre Mikkelsen commented on patch set 4 03/30/17, 10:46

    Benni, I can have a look, but don't know when I'll find the time, to be honest i completely forgot about this again.
  4. Tomas Norre Mikkelsen uploaded patch set 5 07/13/17, 16:10

  5. TYPO3com voted on patch set 5 V +1 07/13/17, 16:20 Completed build in 10m 36s on Thu, 13 Jul, 06:20 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13114

  6. Jörg Bösche commented on patch set 5 CR -1 07/13/17, 16:36

    LostFilesCommand.php:116

    Move the variable outside the else context as default. $customPath = ''. You do not need the else in this case.
  7. Tomas Norre Mikkelsen commented on patch set 5 07/13/17, 16:41

    LostFilesCommand.php:116 Reply

    You mean declaring it before the if ? I did it similar to the excludePaths that why i did the it in the else part.
  8. Jörg Bösche commented on patch set 5 07/13/17, 16:56

    > (1 comment) Yes, place the variable(s) before the if condition(s).
  9. Tomas Norre Mikkelsen commented on patch set 5 07/13/17, 17:03

    Should I do it for the $excludedPaths = [] as well ? I better leave it as it's not part of this bugfix.
  10. Jörg Bösche commented on patch set 5 07/13/17, 17:05

    > Should I do it for the $excludedPaths = [] as well ? > > I better leave it as it's not part of this bugfix. Leave it as it is and create a new issue for refactoring the $excludePaths variable in code.
  11. Wolfgang Klinger commented on patch set 5 07/13/17, 19:54

    LostFilesCommand.php:184

    Better error message: 'The path "' . $customPath . ' is invalid.'
  12. Tomas Norre Mikkelsen uploaded patch set 6 07/13/17, 20:41

  13. TYPO3com voted on patch set 6 V +1 07/13/17, 20:51 Completed build in 09m 46s on Thu, 13 Jul, 10:51 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13137

  14. Jörg Bösche voted on patch set 6 CR +1 07/13/17, 21:51

  15. Stefan Rotsch commented on patch set 6 07/14/17, 10:18

    LostFilesCommand.php:50

    I'm not convinced of the camel cased customPath here, why not just "custom path" or "custom paths"? It does not even directly reflect the parameter name

    LostFilesCommand.php:115

    You should use plural "Paths" here, to (a) be consistent with the parameter used in findLostFiles() and (b) as it could be more than one path

    LostFilesCommand.php:170

    You might move the trimExplode() to the parent method, to keep the parameters consistent… both contain a list of paths, but one is an array, the other a string list

    LostFilesCommand.php:182

    You might break up this line at the or operator, it is pretty long
  16. Tomas Norre Mikkelsen uploaded patch set 7 07/14/17, 11:49

  17. Tomas Norre Mikkelsen commented on patch set 6 07/14/17, 11:50

    LostFilesCommand.php:50 Reply

    Done

    LostFilesCommand.php:170 Reply

    I don't like it in the parent method, but don't want to change the exclude part as it's not part of this fix.

    LostFilesCommand.php:182 Reply

    Done
  18. TYPO3com voted on patch set 7 V +1 07/14/17, 11:59 Completed build in 09m 43s on Fri, 14 Jul, 01:59 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13152

  19. Stefan Rotsch voted on patch set 7 CR +1 07/14/17, 19:01

  20. Benni Mack voted on patch set 7 CR +1 07/28/17, 10:40

  21. Jörg Bösche voted on patch set 7 CR +1 07/31/17, 09:01

  22. Henning Liebe voted on patch set 7 CR +1 V +1 08/07/17, 09:51

  23. Susi Moog voted on patch set 7 CR +2 V +2 08/09/17, 06:49

  24. Gerrit merged patch set 7 08/09/17, 06:49

  25. Susi Moog commented on patch set 8 08/09/17, 06:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e87a625f5b6f5d820640f14cca296db86cd8d399