45238[BUGFIX] Extend Lowlevel lost_files to accept customPath
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Stefan Rotsch +1
- Jörg Bösche +1
- Henning Liebe +1
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Henning Liebe +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2831
Show 6 earlier messages
-
Tomas Norre Mikkelsen uploaded patch set 1 12/14/15, 14:18
-
Erik Frister commented on patch set 1 CR -1 01/05/16, 10:13
Please check the comments in the reviewLostFilesCommand.php:34Maybe it makes sense to mention that it will use /uploads by default if --customPaths are not specified. Additionally, the task now takes two parameters: --excludePath --customPaths Both take csv lists, but one is singular, one is plural. It probably makes sense to rename --customPaths to --customPath to stay consistentLostFilesCommand.php:89CGL Violation. Should be "true" rather than "TRUE". PSR-2LostFilesCommand.php:91false rather than FALSE. -
Tomas Norre Mikkelsen uploaded patch set 2 01/05/16, 12:18
-
Erik Frister commented on patch set 2 CR -1 01/05/16, 12:56
LostFilesCommand.php:34Needs to be mentioned that the default path is /uploads. That is not obvious.LostFilesCommand.php:36customPaths is still used in the help. Please adjust. -
Tomas Norre Mikkelsen uploaded patch set 3 01/05/16, 13:04
-
Irene Höppner commented on patch set 3 CR +1 01/08/16, 15:01
Looks good for me.I would like to have this a little less technical like "Add the possibility to add custom paths to the low level lost_files command" (but shorter than this)
-
Tomas Norre Mikkelsen uploaded patch set 4 03/07/16, 15:13
-
Benni Mack commented on patch set 4 03/28/17, 09:09
Hey tomas, you want to pick that up now that we're all up and running with Symfony Console? Also, I consider this a bugfix or task, because the current behaviour can be harmful if no subfolder etc. can be specified. no "feature". -
Tomas Norre Mikkelsen commented on patch set 4 03/30/17, 10:46
Benni, I can have a look, but don't know when I'll find the time, to be honest i completely forgot about this again. -
Tomas Norre Mikkelsen uploaded patch set 5 07/13/17, 16:10
-
TYPO3com voted on patch set 5 V +1 07/13/17, 16:20 Completed build in 10m 36s on Thu, 13 Jul, 06:20 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13114
-
Jörg Bösche commented on patch set 5 CR -1 07/13/17, 16:36
LostFilesCommand.php:116Move the variable outside the else context as default. $customPath = ''. You do not need the else in this case. -
Tomas Norre Mikkelsen commented on patch set 5 07/13/17, 16:41
LostFilesCommand.php:116ReplyYou mean declaring it before the if ? I did it similar to the excludePaths that why i did the it in the else part. -
Jörg Bösche commented on patch set 5 07/13/17, 16:56
> (1 comment) Yes, place the variable(s) before the if condition(s). -
Tomas Norre Mikkelsen commented on patch set 5 07/13/17, 17:03
Should I do it for the $excludedPaths = [] as well ? I better leave it as it's not part of this bugfix. -
Jörg Bösche commented on patch set 5 07/13/17, 17:05
> Should I do it for the $excludedPaths = [] as well ? > > I better leave it as it's not part of this bugfix. Leave it as it is and create a new issue for refactoring the $excludePaths variable in code. -
Wolfgang Klinger commented on patch set 5 07/13/17, 19:54
LostFilesCommand.php:184Better error message: 'The path "' . $customPath . ' is invalid.' -
Tomas Norre Mikkelsen uploaded patch set 6 07/13/17, 20:41
-
TYPO3com voted on patch set 6 V +1 07/13/17, 20:51 Completed build in 09m 46s on Thu, 13 Jul, 10:51 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13137
-
Jörg Bösche voted on patch set 6 CR +1 07/13/17, 21:51
-
Stefan Rotsch commented on patch set 6 07/14/17, 10:18
LostFilesCommand.php:50I'm not convinced of the camel cased customPath here, why not just "custom path" or "custom paths"? It does not even directly reflect the parameter nameLostFilesCommand.php:115You should use plural "Paths" here, to (a) be consistent with the parameter used in findLostFiles() and (b) as it could be more than one pathLostFilesCommand.php:170You might move the trimExplode() to the parent method, to keep the parameters consistent… both contain a list of paths, but one is an array, the other a string listLostFilesCommand.php:182You might break up this line at the or operator, it is pretty long -
Tomas Norre Mikkelsen uploaded patch set 7 07/14/17, 11:49
-
Tomas Norre Mikkelsen commented on patch set 6 07/14/17, 11:50
LostFilesCommand.php:50ReplyDoneLostFilesCommand.php:170ReplyI don't like it in the parent method, but don't want to change the exclude part as it's not part of this fix.LostFilesCommand.php:182ReplyDone -
TYPO3com voted on patch set 7 V +1 07/14/17, 11:59 Completed build in 09m 43s on Fri, 14 Jul, 01:59 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13152
-
Stefan Rotsch voted on patch set 7 CR +1 07/14/17, 19:01
-
Benni Mack voted on patch set 7 CR +1 07/28/17, 10:40
-
Jörg Bösche voted on patch set 7 CR +1 07/31/17, 09:01
-
Henning Liebe voted on patch set 7 CR +1 V +1 08/07/17, 09:51
-
Susi Moog voted on patch set 7 CR +2 V +2 08/09/17, 06:49
-
Gerrit merged patch set 7 08/09/17, 06:49
-
Susi Moog commented on patch set 8 08/09/17, 06:50
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e87a625f5b6f5d820640f14cca296db86cd8d399