Review main Merged

45253[BUGFIX] Workspace page previews collide with generated preview links

Oliver Hader CR +2 V +2 Easy +5 −5 updated 03/06/16, 01:33

Commit message

Workspace page previews collide with that configuration that might have
been set by using a preview link containing a ADMCMD_prev command. The
keyword "IGNORE" is introduced to actually ignore these configurations
when viewing a page from the workspace module.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1

Issues 1

Files 2

Review log 11

  1. Oliver Hader uploaded patch set 1 12/14/15, 21:54

  2. Daniel Goerz commented on patch set 1 12/14/15, 22:01

    PreviewHook.php:156

    Now $inputCode = '' gets through, which did not before.
  3. Oliver Hader commented on patch set 1 12/14/15, 22:33

    Good catch!
  4. Oliver Hader uploaded patch set 2 12/14/15, 22:36

  5. Daniel Goerz voted on patch set 2 CR +1 12/14/15, 22:39

  6. Morton Jonuschat voted on patch set 2 CR +1 12/15/15, 05:52

  7. Wouter Wolters wrote 01/11/16, 21:50

    Patch set 3: Commit message was updated.
  8. Wouter Wolters voted on patch set 3 CR +1 01/11/16, 21:50

  9. Mathias Schreiber voted on patch set 3 CR +1 V +1 03/05/16, 22:57

  10. Benni Mack voted on patch set 3 CR +2 V +2 03/06/16, 01:26

  11. Gerrit merged patch set 3 03/06/16, 01:33