Review main Abandoned

45289[BUGFIX] Fluid: Handle CheckboxViewHelper with proper typecast

Thomas Schlumberger CR 0 V 0 Easy +1 −1 updated 12/15/15, 12:29

Commit message

When using the Form.CheckboxViewHelper the check for identifying
if the property $checked is true, the typecast is missing, thus
resulting in a way that never checks a checkbox for all non-property
values (not having "property="" but only using "name="abcdef" checked="true").

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Thomas Schlumberger uploaded patch set 1 12/15/15, 11:38

  2. Andreas Kienast commented on patch set 1 12/15/15, 11:40

    Are unit tests possible for this fix?
  3. Wouter Wolters commented on patch set 1 CR -1 12/15/15, 11:41

    Is already fixed with https://review.typo3.org/#/c/45246/ ?
  4. Thomas Schlumberger commented on patch set 1 12/15/15, 11:54

    Ah i see - thanks Wouter. I did not find this patch on my initial search
  5. Wouter Wolters commented on patch set 1 12/15/15, 12:06

    That change is included in the 7.6.1 release. Is these change than obsolete and ready for abandoning?
  6. Thomas Schlumberger commented on patch set 1 12/15/15, 12:13

    Yeah, just tested the other patch quickly. So the change I made is obsolete. Thanks for your time.
  7. Mathias Schreiber abandoned the change 12/15/15, 12:29

    Abandoned due to user request