Review main Merged

45293[BUGFIX] Initialize attribute in RequestBuilder with correct type

Sascha Egerer CR +2 V +2 Easy +3 −3 updated 01/09/16, 08:06

Commit message

The correct type for `defaultControllerName` is string.
Also cast all assigned values to strings, so a check with
empty() works as expected.

Review

  • Code review CR +2
    • Sascha Egerer +2
  • Verified V +2
    • Sascha Egerer +2

Issues 1

Files 1

Review log 24

  1. Sascha Egerer uploaded patch set 1 12/15/15, 17:14

  2. Markus Klein commented on patch set 2 12/15/15, 20:25

    Published edit on patch set 1
  3. Markus Klein voted on patch set 2 CR +1 V +1 12/15/15, 20:26

  4. Andreas Kienast voted on patch set 2 CR +1 12/16/15, 08:03

  5. Mathias Brodala commented on patch set 2 12/16/15, 08:36

    RequestBuilder.php:202

    How about making this empty($this->defaultControllerName) instead? This would catch cases where 3rd party code sets it to NULL again.
  6. Sascha Egerer commented on patch set 2 12/16/15, 10:28

    RequestBuilder.php:202 Reply

    Also thought about that. But the value is of type string. So it should be set as string. The question is if we should take care about broken 3rd party code here
  7. Sascha Egerer uploaded patch set 3 12/31/15, 16:35

  8. Sascha Egerer commented on patch set 2 12/31/15, 16:36

    RequestBuilder.php:202 Reply

    I've changed that now to empty()
  9. Markus Klein wrote 01/02/16, 00:08

    Patch set 4: Published edit on patch set 3.
  10. Markus Klein voted on patch set 4 CR +1 V +1 01/02/16, 00:08

  11. Sascha Egerer commented on patch set 4 01/02/16, 07:33

    Sorry and thanks again for your fix
  12. Mathias Brodala voted on patch set 4 CR +1 01/04/16, 07:59

  13. anonymized-112664 voted on patch set 4 CR +1 01/05/16, 16:51

  14. Andreas Kienast voted on patch set 4 CR +1 01/06/16, 17:06

  15. Daniel Goerz voted on patch set 4 CR +1 01/08/16, 20:52

  16. Markus Klein wrote 01/08/16, 22:14

    Patch set 5: Commit message was updated.
  17. Markus Klein voted on patch set 5 CR +1 V +1 01/08/16, 22:14

  18. Anja Leichsenring voted on patch set 5 CR +1 V +1 01/08/16, 22:15

  19. Daniel Goerz voted on patch set 5 CR +1 01/08/16, 22:24

  20. Andreas Kienast voted on patch set 5 CR +1 01/09/16, 05:01

  21. Sascha Egerer uploaded patch set 6 01/09/16, 08:03

  22. Sascha Egerer commented on patch set 6 01/09/16, 08:04

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 9b425292c39f59d418d0bc89e07d51e2fc86eecf
  23. Sascha Egerer voted on patch set 6 CR +2 V +2 01/09/16, 08:06

  24. Gerrit merged patch set 6 01/09/16, 08:06