Review main Merged

45327[BUGFIX] Add buttons with `form` attribute to SplitButton save handling

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 12/17/15, 14:00

Commit message

Some save buttons do not follow the `_save` naming convention, but have
a `form` attribute instead. IE does not support such attribute which
breaks the save buttons. Now all buttons with a `form` attribute are
added to the save button handling. To prevent side effects, the buttons
must be in the module header now.

Review

  • Code review CR +2
    • Markus Klein +2
    • Roman Schürmann +1
  • Verified V +2
    • Markus Klein +2
    • Roman Schürmann +1

Issues 2

Files 1

Review log 13

  1. Andreas Kienast uploaded patch set 1 12/17/15, 10:34

  2. Andreas Kienast commented on patch set 2 12/17/15, 10:38

    Published edit on patch set 1
  3. Michael Oehlhof voted on patch set 2 CR +1 12/17/15, 10:39

  4. Mathias Brodala voted on patch set 2 CR +1 12/17/15, 10:42

  5. Roman Schürmann voted on patch set 2 CR +1 12/17/15, 11:02

  6. Roman Schürmann voted on patch set 2 V +1 12/17/15, 11:13

  7. Christian Kuhn voted on patch set 2 CR +1 12/17/15, 11:56

  8. Markus Klein commented on patch set 2 12/17/15, 13:26

    SplitButtons.js:41

    This useless, right? Any click event on any of the elements, which are all inside document, is still handled.
  9. Andreas Kienast commented on patch set 3 12/17/15, 13:33

    Published edit on patch set 2
  10. Markus Klein voted on patch set 3 CR +1 12/17/15, 13:35

  11. Roman Schürmann voted on patch set 3 CR +1 V +1 12/17/15, 13:45

  12. Markus Klein voted on patch set 3 CR +2 V +2 12/17/15, 14:00

  13. Gerrit merged patch set 3 12/17/15, 14:00