Review main Merged

45338[BUGFIX] DBAL: use correct default value for native connection

Melanie Kalka CR +2 V +2 Easy +1 −1 updated 12/17/15, 16:21

Commit message

DBAL uses an empty string for the portnumber parameter
for mysqli real_connect, which results in a PHP warning,
because an integer (or null) is required.

Changing the fallback to null resolves this issue and
results in a working database connection.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 1

Review log 5

  1. Melanie Kalka uploaded patch set 1 12/17/15, 15:23

  2. Markus Klein commented on patch set 2 12/17/15, 15:45

    Published edit on patch set 1
  3. Markus Klein commented on patch set 2 CR +1 V +1 12/17/15, 15:45

    Thanks!
  4. Andreas Kienast voted on patch set 2 CR +2 V +2 12/17/15, 16:21

  5. Gerrit merged patch set 2 12/17/15, 16:21