Review main Merged

45346[BUGFIX] Change DB field folder for sys_file_collection to allow NULL

Morton Jonuschat CR +2 V +2 Easy +2 −1 updated 12/30/15, 17:00

Commit message

Change the database schema to not require a value in the optional folder
column of the sys_file_collection table. Data for this field is only
provided when the type of collection created in the backend is based on
a folder, leading to errors in MySQL strict mode.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 2

Review log 13

  1. Morton Jonuschat uploaded patch set 1 12/18/15, 08:19

  2. Morton Jonuschat commented on patch set 1 CR -1 12/18/15, 08:20

    Needs to wait for 7.6 to be branched due to schema changes
  3. Oliver Hader commented on patch set 1 CR +1 12/18/15, 09:24

    I'd say it's fine for 7.6 since the schema change is not required but helps to fix a bug on new installations with 7.6. So, I consider that non-invasive for 7.6
  4. Morton Jonuschat commented on patch set 1 CR 0 12/18/15, 09:29

    Totally fine by me
  5. Morton Jonuschat commented on patch set 1 12/21/15, 16:52

    7.6 has been branched, ready for review
  6. Wouter Wolters voted on patch set 1 CR +1 12/21/15, 22:33

  7. Wouter Wolters voted on patch set 1 V +1 12/30/15, 13:42

  8. Morton Jonuschat commented on patch set 2 12/30/15, 14:11

    Published edit on patch set 1
  9. Benni Mack voted on patch set 2 CR +1 V +1 12/30/15, 14:16

  10. Oliver Hader voted on patch set 2 CR +1 12/30/15, 15:36

  11. Wouter Wolters voted on patch set 2 CR +2 V +2 12/30/15, 16:59

  12. Gerrit merged patch set 2 12/30/15, 17:00

  13. Wouter Wolters commented on patch set 3 12/30/15, 17:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 3dbe8be04f6af35747c2b8479076174ca7b92397